Ticket #1378: allowSelection.2.patch

theme/default/style.css

@@ -240 +240 @@
-  background: url("../../img/close.gif") no-repeat;
-  cursor: pointer;
-}
+
+.olControlNoSelect {
+ -moz-user-select: none;
+}

lib/OpenLayers/Control.js

@@ -79 +79 @@
-    type: null, 
-
-    /** 
+     * Property: allowSelection
+     * {Boolean} By deafault, controls do not allow selection, because
+     * it may interfere with map dragging. If this is true, OpenLayers
+     * will not prevent selection of the control.
+     * Default is false.
+     */
+    allowSelection: false,  
+
+    /** 
-     * Property: displayClass 
-     * {string}  This property is used for CSS related to the drawing of the
-     * Control. 
@@ -240 +249 @@
-        if (this.div == null) {
-            this.div = OpenLayers.Util.createDiv(this.id);
-            this.div.className = this.displayClass;
+            if (!this.allowSelection) {
+                this.div.className += " olControlNoSelect";
+                this.div.setAttribute("unselectable", "on", 0);
+                this.div.onselectstart = function() { return(false); }; 
+            }    
-            if (this.title != "") {
-                this.div.title = this.title;
-            }

lib/OpenLayers/Control/OverviewMap.js

@@ -204 +204 @@
-        // Optionally add min/max buttons if the control will go in the
-        // map viewport.
-        if(!this.outsideViewport) {
-=
++= " " +
-            var imgLocation = OpenLayers.Util.getImagesLocation();
-            // maximize button div
-            var img = imgLocation + 'layer-switcher-maximize.png';

lib/OpenLayers/Control/MousePosition.js

@@ -91 +91 @@
-        if (!this.element) {
-            this.div.left = "";
-            this.div.top = "";
-            this.div.className = this.displayClass;
-            this.element = this.div;
-        }
-        

lib/OpenLayers/Control/Permalink.js

@@ -109 +109 @@
-        OpenLayers.Control.prototype.draw.apply(this, arguments);
-          
-        if (!this.element) {
-            this.div.className = this.displayClass;
-            this.element = document.createElement("a");
-            this.element.innerHTML = OpenLayers.i18n("permalink");
-            this.element.href="";

lib/OpenLayers/Control/Scale.js

@@ -43 +43 @@
-        OpenLayers.Control.prototype.draw.apply(this, arguments);
-        if (!this.element) {
-            this.element = document.createElement("div");
-            this.div.className = this.displayClass;
-            this.div.appendChild(this.element);
-        }
-        this.map.events.register( 'moveend', this, this.updateScale);

lib/OpenLayers/Control/ScaleLine.js

@@ -81 +81 @@
-    draw: function() {
-        OpenLayers.Control.prototype.draw.apply(this, arguments);
-        if (!this.eTop) {
-            this.div.className = this.displayClass;
-            this.div.style.display = "block";
-            this.div.style.position = "absolute";
-