Ticket #761: vector.patch

lib/OpenLayers/Layer/Vector.js

@@ -363 +363 @@
-     * {<OpenLayers.Feature.Vector>} A feature if one was under the event.
-     */
-    getFeatureFromEvent: function(evt) {
+        if (!this.renderer) {
+            OpenLayers.Console.error("getFeatureFromEvent called on layer with no renderer. This usually means you destroyed a layer, but not some handler which is associated with it."); 
+            return null;
+        }    
-        var featureId = this.renderer.getFeatureIdFromEvent(evt);
-        return this.getFeatureById(featureId);
-    },

tests/Layer/test_Vector.html

@@ -148 +148 @@
-    }
-
-    function test_99_Layer_Vector_destroy (t) {
-1
+2
-        layer = new OpenLayers.Layer.Vector(name);
-        var map = new OpenLayers.Map('map');
-        map.addLayer(layer);
-        layer.destroy();
-        t.eq(layer.map, null, "layer.map is null after destroy");
+        t.eq(layer.getFeatureFromEvent({'target':'map'}), null, "getFeatureIdFromEvent doesn't cause an error when called on layer which has been destroyed.");
-    }
-
-    function test_Layer_Vector_externalGraphic(t) {