OpenLayers OpenLayers

Ticket #800: mergeNewParams.patch

File mergeNewParams.patch, 2.6 kB (added by euzuro, 1 year ago)

using our favorite new redraw() function, mergeNewParameters() becomes much simpler. Just do the magic at the HTTPRequest level, where it should have been from the start. Lines inserted: 1. Lines deleted: 33. Vive la france!

  • lib/OpenLayers/Layer/Grid.js

    old new  
    395395    addTile:function(bounds, position) { 
    396396        // Should be implemented by subclasses 
    397397    }, 
    398  
    399     /** 
    400      * APIMethod: mergeNewParams 
    401      * Once params have been changed, we will need to re-init our tiles 
    402      * 
    403      * Parameters: 
    404      * newParams - {Object} Hashtable of new params to use 
    405      */ 
    406     mergeNewParams:function(newArguments) { 
    407         OpenLayers.Layer.HTTPRequest.prototype.mergeNewParams.apply(this, 
    408                                                                 [newArguments]); 
    409  
    410         if (this.map != null) { 
    411             this._initTiles(); 
    412         } 
    413     }, 
    414  
    415398     
    416399    /** 
    417400     * Method: shiftRow 
  • lib/OpenLayers/Layer/HTTPRequest.js

    old new  
    115115     */ 
    116116    mergeNewParams:function(newParams) { 
    117117        this.params = OpenLayers.Util.extend(this.params, newParams); 
     118        this.redraw(); 
    118119    }, 
    119120     
    120121    /** 
  • lib/OpenLayers/Layer/MapServer/Untiled.js

    old new  
    245245    }, 
    246246 
    247247    /**  
    248      * APIMethod: mergeNewParams 
    249      * Once HTTPRequest has updated new params, reload the image div 
    250      * 
    251      * Parameters: 
    252      * newParams - {Object}  
    253      */ 
    254     mergeNewParams:function(newParams) { 
    255         OpenLayers.Layer.HTTPRequest.prototype.mergeNewParams.apply(this,  
    256                                                                  [newParams]); 
    257         //redraw 
    258         this.moveTo(null, true); 
    259     }, 
    260      
    261     /**  
    262248    * APIMethod: getFullRequestString 
    263249    * combine the layer's url with its params and these newParams.  
    264250    *    
  • lib/OpenLayers/Layer/WMS/Untiled.js

    old new  
    272272        var newArguments = [upperParams]; 
    273273        OpenLayers.Layer.HTTPRequest.prototype.mergeNewParams.apply(this,  
    274274                                                                 newArguments); 
    275         //redraw 
    276         this.moveTo(null, true); 
    277275    }, 
    278276     
    279277    /**