Changeset 1503

Timestamp:

09/26/06 17:46:10 (2 years ago)

Author:

euzuro

Message:

small cleanup of basic OpenLayers.Feature functionality -- specifically adding full control for popup and marker creation and destruction and better comments for all that. all tests pass.

Files:

• trunk/openlayers/lib/OpenLayers/Feature.js (modified) (5 diffs)

trunk/openlayers/lib/OpenLayers/Feature.js

@@ -68 +68 @@
-        }
-        if (this.popup != null) {
-popup.destroy(
+destroyPopup(this.popup
-            this.popup = null;
-        }
@@ -77 +77 @@
-     * @returns A Marker Object created from the 'lonlat' and 'icon' properties
-     *          set in this.data. If no 'lonlat' is set, returns null. If no
-
+
+
+
+
-     * @type OpenLayers.Marker
-     */
@@ -90 +93 @@
-    },
-
+    /** If user overrides the createMarker() function, s/he should be able
+     *   to also specify an alternative function for destroying it
+     */
-    destroyMarker: function() {
-        this.marker.destroy();  
@@ -95 +101 @@
-
-    /**
+     * @returns A Popup Object created from the 'lonlat', 'popupSize',
+     *          and 'popupContentHTML' properties set in this.data. It uses
+     *          this.marker.icon as default anchor. 
+     *          
+     *          If no 'lonlat' is set, returns null. 
+     *          If no this.marker has been created, no anchor is sent.
-     * 
+     *          Note: this.popup is set to return value
+     * 
+     * @type OpenLayers.Popup.AnchoredBubble
-     */
-    createPopup: function() {
@@ -113 +128 @@
-    },
-
+    
+    /** As with the marker, if user overrides the createPopup() function, s/he 
+     *   should also be able to override the destruction
+     */
+    destroyPopup: function() {
+        this.popup.destroy() 
+    },
+    
-    CLASS_NAME: "OpenLayers.Feature"
-};