Changeset 2539

Timestamp:

03/08/07 14:58:20 (2 years ago)

Author:

sderle

Message:

Map.addLayer() will return false when adding duplicate layers. Fixes #248.

Files:

• trunk/openlayers/lib/OpenLayers/Map.js (modified) (1 diff)
• trunk/openlayers/tests/test_Map.html (modified) (1 diff)

trunk/openlayers/lib/OpenLayers/Map.js

@@ -300 +300 @@
-    */    
-    addLayer: function (layer) {
+        for(var i=0; i < this.layers.length; i++) {
+            if (this.layers[i] == layer) {
+                return false;
+            }
+        }    
+        
-        layer.div.style.overflow = "";
-        this.setLayerZIndex(layer, this.layers.length);

trunk/openlayers/tests/test_Map.html

@@ -219 +219 @@
-
-        t.ok( gotLayer == null, "getLayer correctly returns null when layer not found");
+    }
+    
+    function test_11_Map_double_addLayer(t) {
+        t.plan( 1 );    
+        map = new OpenLayers.Map($('map'));
+        layer = new OpenLayers.Layer.WMS('Test Layer', 
+                    "http://octo.metacarta.com/cgi-bin/mapserv", 
+                    {map: '/mapdata/vmap_wms.map', layers: 'basic', format: 'image/jpeg'} 
+                    );
+
+        map.addLayers([layer,layer]);
+        
+        t.eq( map.layers.length, 1, "Map does not allow double adding of layers." );
+    
-    }
-