Changeset 2894

Timestamp:

03/25/07 20:50:31 (2 years ago)

Author:

crschmidt

Message:

Commit small change to destroy events objects when destroying objects with
events. This removes a number of minor memory leaks with creating/destroying
popups, layers, features, and markers.

Files:

• trunk/openlayers/lib/OpenLayers/Feature.js (modified) (1 diff)
• trunk/openlayers/lib/OpenLayers/Layer.js (modified) (1 diff)
• trunk/openlayers/lib/OpenLayers/Marker.js (modified) (1 diff)
• trunk/openlayers/lib/OpenLayers/Popup.js (modified) (1 diff)
• trunk/openlayers/tests/test_Events.html (modified) (1 diff)

trunk/openlayers/lib/OpenLayers/Feature.js

@@ -60 +60 @@
-        }
-
+        if (this.events) {
+            this.events.destroy();
+        }
-        this.events = null;
+        
-        this.layer = null;
-        this.id = null;

trunk/openlayers/lib/OpenLayers/Layer.js

@@ -155 +155 @@
-        this.div = null;
-        this.options = null;
+        
+        this.events.destroy();
-        this.events = null;
-    },

trunk/openlayers/lib/OpenLayers/Marker.js

@@ -48 +48 @@
-    destroy: function() {
-        this.map = null;
-
+
+
+
+
-        if (this.icon != null) {
-            this.icon.destroy();

trunk/openlayers/lib/OpenLayers/Popup.js

@@ -118 +118 @@
-        if (this.map != null) {
-            this.map.removePopup(this);
-
+
+
+
+
-        this.div = null;
-        this.map = null;
-    },
-

trunk/openlayers/tests/test_Events.html

@@ -213 +213 @@
-             start + OpenLayers.Events.prototype.BROWSER_EVENTS.length + 1,
-             "construction increases the number of event observers");
-
+
+
-        t.eq(OpenLayers.Event.observers.length, start,
-             "destruction restores the number of event observers");