Changeset 3041

Timestamp:

04/10/07 06:30:49 (2 years ago)

Author:

crschmidt

Message:

Commit Fix for #654: Layer should not redraw on setVisibility(false). For
some layers, this is a significant performance enhancement. Includes regression
tests.

Files:

• trunk/openlayers/lib/OpenLayers/Layer.js (modified) (1 diff)
• trunk/openlayers/tests/test_Layer.html (modified) (2 diffs)

trunk/openlayers/lib/OpenLayers/Layer.js

@@ -348 +348 @@
-            this.visibility = visibility;
-            this.display(visibility);
-
+visibility && 
-                var extent = this.map.getExtent();
-                if (extent != null) {

trunk/openlayers/tests/test_Layer.html

@@ -119 +119 @@
-    function test_05_Layer_visibility(t) {
-
-3
+5
-
-        var layer = new OpenLayers.Layer('Test Layer');
@@ -130 +130 @@
-        layer.setVisibility(true);
-        t.eq(layer.getVisibility(), true, "setVisibility true works");
+       
+        // Need a map in order to have moveTo called.
+        // Tests added for #654.
+        var layer = new OpenLayers.Layer.WMS('Test Layer','http://example.com');
+        var m = new OpenLayers.Map('map');
+        m.addLayer(layer);
+        m.zoomToMaxExtent();
+        
+        layermoved = false; 
+        layer.moveTo = function() { layermoved = true; }
+        
+        layer.setVisibility(false);
+        t.eq(layermoved, false, "Layer didn't move when calling setvis false");
+        
+        layer.setVisibility(true);
+        t.eq(layermoved, true, "Layer moved when calling setvis true.");
-    
-    }