Changeset 4070

Timestamp:

08/28/07 11:06:12 (1 year ago)

Author:

crschmidt

Message:

Write more tests for the GML Format. This has highlighted two bugs:

• We don't parse multipoint or multilinestring correctly.
  
• PostGIS doesn't export correct Polygon GML via as GML.
  

I'm about to start working on the first, and I'll report the latter
soon.

Files:

• sandbox/tschaub/xml/tests/Format/test_GML.html (modified) (2 diffs)

sandbox/tschaub/xml/tests/Format/test_GML.html

@@ -35 +35 @@
-        t.eq(data[0].geometry.getBounds().toBBOX(), "-1254041.389712,250906.951598,-634517.119991,762236.29408", "Reading 3d content returns geometry with correct bounds (no 0,0)");
-        t.eq(data[0].geometry.CLASS_NAME, "OpenLayers.Geometry.Polygon", "Reading 3d content returns polygon geometry");
+    }   
+    function test_Format_GML_read_point_geom(t) {
+        t.plan(3);
+        
+        var point = shell_start + geoms['point'] + shell_end;
+        var parser = new OpenLayers.Format.GML();
+        data = parser.read(point);
+        t.eq(data[0].geometry.CLASS_NAME, "OpenLayers.Geometry.Point", "Point GML returns correct classname");
+        t.eq(data[0].geometry.x, 1, "x coord correct");
+        t.eq(data[0].geometry.y, 2, "y coord correct");
-    }    
+    function test_Format_GML_read_linestring_geom(t) {
+        t.plan(5);
+        
+        var line = shell_start + geoms['linestring'] + shell_end;
+        var parser = new OpenLayers.Format.GML();
+        data = parser.read(line);
+        t.eq(data[0].geometry.CLASS_NAME, "OpenLayers.Geometry.LineString", "LineString GML returns correct classname");
+        t.eq(data[0].geometry.components[0].x, 1, "first x coord correct");
+        t.eq(data[0].geometry.components[0].y, 2, "first y coord correct");
+        t.eq(data[0].geometry.components[1].x, 4, "second x coord correct");
+        t.eq(data[0].geometry.components[1].y, 5, "second y coord correct");
+    }    
+    function test_Format_GML_read_polygon_geom(t) {
+        t.plan(7);
+        
+        var polygon = shell_start + geoms['polygon'] + shell_end;
+        var parser = new OpenLayers.Format.GML();
+        data = parser.read(polygon);
+        t.eq(data[0].geometry.CLASS_NAME, "OpenLayers.Geometry.Polygon", "Polygon GML returns correct classname");
+        t.eq(data[0].geometry.components[0].components[0].x, 1, "first x coord correct");
+        t.eq(data[0].geometry.components[0].components[0].y, 2, "first y coord correct");
+        t.eq(data[0].geometry.components[0].components[1].x, 4, "second x coord correct");
+        t.eq(data[0].geometry.components[0].components[1].y, 5, "second y coord correct");
+        t.eq(data[0].geometry.components[0].components.length, 4, "coords length correct");
+        t.eq(data[0].geometry.components.length, 1, "rings length correct");
+    }   
+    function test_Format_GML_read_multipoint_geom(t) {
+        t.plan(1);
+        
+        var multipoint = shell_start + geoms['multipoint'] + shell_end;
+        var parser = new OpenLayers.Format.GML();
+        data = parser.read(multipoint);
+        console.log(data);
+        t.eq(data[0].geometry.CLASS_NAME, "OpenLayers.Geometry.MultiPoint", "MultiPoint GML returns correct classname (GML was: " + multipoint + ")");
+        /* t.eq(data[0].geometry.components[0].x, 1, "x coord correct");
+        t.eq(data[0].geometry.components[0].y, 2, "y coord correct");
+        t.eq(data[0].geometry.components.length, 2, "length correct");
+        t.eq(data[0].geometry.components[1].x, 4, "x coord correct");
+        t.eq(data[0].geometry.components[1].y, 5, "y coord correct");
+        */
+    }    
+    function test_Format_GML_read_multilinestring_geom(t) {
+        t.plan(1);
+        
+        var multilinestring = shell_start + geoms['multipoint'] + shell_end;
+        var parser = new OpenLayers.Format.GML();
+        data = parser.read(multilinestring);
+        t.eq(data[0].geometry.CLASS_NAME, "OpenLayers.Geometry.MultiLineString", "MultiLineString GML returns correct classname (GML was: " + multilinestring + ")");
+        /* t.eq(data[0].geometry.components[0].x, 1, "x coord correct");
+        t.eq(data[0].geometry.components[0].y, 2, "y coord correct");
+        t.eq(data[0].geometry.components.length, 2, "length correct");
+        t.eq(data[0].geometry.components[1].x, 4, "x coord correct");
+        t.eq(data[0].geometry.components[1].y, 5, "y coord correct");
+        */
+    }    
+    /*
+    function test_Format_GML_read_polygon_with_holes_geom(t) {
+        t.plan(5);
+        
+        var polygon_with_holes = shell_start + geoms['polygon_with_holes'] + shell_end;
+        console.log(polygon_with_holes);
+        var parser = new OpenLayers.Format.GML();
+        data = parser.read(polygon_with_holes);
+        console.log(data[0].geometry);
+        t.eq(data[0].geometry.CLASS_NAME, "OpenLayers.Geometry.Polygon", "Polygon GML returns correct classname");
+        t.eq(data[0].geometry.components[0].components[0].x, 1, "first x coord correct");
+        t.eq(data[0].geometry.components[0].components[0].y, 2, "first y coord correct");
+        t.eq(data[0].geometry.components[0].components[1].x, 4, "second x coord correct");
+        t.eq(data[0].geometry.components[0].components[1].y, 5, "second y coord correct");
+        t.eq(data[0].geometry.components[0].components.length, 4, "coords length correct");
+        t.eq(data[0].geometry.components[1].components[0].x, 11, "first x coord correct");
+        t.eq(data[0].geometry.components[1].components[0].y, 12, "first y coord correct");
+        t.eq(data[0].geometry.components[1].components[1].x, 14, "second x coord correct");
+        t.eq(data[0].geometry.components[1].components[1].y, 15, "second y coord correct");
+        t.eq(data[0].geometry.components[1].components.length, 4, "coords length correct");
+        t.eq(data[0].geometry.components.length, 2, "rings length correct");
+    } */    
-    function test_Format_GML_read_attributes(t) {
-        t.plan(1);
-        var parser = new OpenLayers.Format.GML();
-        data = parser.read(test_content[0]);
-        console.log(data[0].attributes);
-        t.eq(data[0].attributes['NAME'], "WY", "Simple Attribute data is read correctly.");
-    }    
@@ -70 +156 @@
- ' <gml:featureMember><fs:scribble fid="8">    <fs:geometry>        <gml:Point><gml:coordinates>-81.38671875,27.0703125</gml:coordinates></gml:Point>         </fs:geometry> ' +
- '        <fs:down>south</fs:down><fs:title>Florida</fs:title>        </fs:scribble></gml:featureMember>' + 
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-        </script> 
-</head>