Changeset 4220

Timestamp:

09/11/07 16:19:35 (1 year ago)

Author:

crschmidt

Message:

Fix for getFeatureFromEvent method on destroyed layer. (Closes #761) Review
by elem (yay)

Files:

• trunk/openlayers/lib/OpenLayers/Layer/Vector.js (modified) (1 diff)
• trunk/openlayers/tests/Layer/test_Vector.html (modified) (2 diffs)

trunk/openlayers/lib/OpenLayers/Layer/Vector.js

@@ -362 +362 @@
-     */
-    getFeatureFromEvent: function(evt) {
+        if (!this.renderer) {
+            OpenLayers.Console.error("getFeatureFromEvent called on layer with no renderer. This usually means you destroyed a layer, but not some handler which is associated with it."); 
+            return null;
+        }    
-        var featureId = this.renderer.getFeatureIdFromEvent(evt);
-        return this.getFeatureById(featureId);

trunk/openlayers/tests/Layer/test_Vector.html

@@ -149 +149 @@
-
-    function test_99_Layer_Vector_destroy (t) {
-1
+2
-        layer = new OpenLayers.Layer.Vector(name);
-        var map = new OpenLayers.Map('map');
@@ -155 +155 @@
-        layer.destroy();
-        t.eq(layer.map, null, "layer.map is null after destroy");
+        t.eq(layer.getFeatureFromEvent({'target':'map'}), null, "getFeatureIdFromEvent doesn't cause an error when called on layer which has been destroyed.");
-    }
-