Changeset 4232

Timestamp:

09/12/07 01:12:00 (1 year ago)

Author:

crschmidt

Message:

Erik helps me fix tests. I threaten to kill him for criticizing my lack
of semicolons. All is well. Fix for "keep selected features drawn with
the right style". (Closes #916)

Files:

• trunk/openlayers/lib/OpenLayers/Control/SelectFeature.js (modified) (2 diffs)
• trunk/openlayers/tests/Control/test_SelectFeature.html (modified) (1 diff)

trunk/openlayers/lib/OpenLayers/Control/SelectFeature.js

@@ -162 +162 @@
-        }
-        this.layer.selectedFeatures.push(feature);
-
+
+
-        this.onSelect(feature);
-    },
@@ -176 +177 @@
-    unselect: function(feature) {
-        // Store feature style for restoration later
-=
-originalStyle = feature.s
-
-, feature.originalStyle
+!
+style = feature.originalS
+
+
-        OpenLayers.Util.removeItem(this.layer.selectedFeatures, feature);
-        this.onUnselect(feature);

trunk/openlayers/tests/Control/test_SelectFeature.html

@@ -31 +31 @@
-        control.destroy();
-        
+    }
+    
+    function test_Control_SelectFeature_select(t) {
+        t.plan(2);
+        var map = new OpenLayers.Map("map");
+        var layer = new OpenLayers.Layer.Vector();
+        map.addLayer(layer);
+        var control = new OpenLayers.Control.SelectFeature(layer);
+        var feature = new OpenLayers.Feature.Vector(new OpenLayers.Geometry.Point(0,0));
+        layer.addFeatures(feature);
+        layer.drawFeature = function() { }
+        control.select(feature);
+        t.eq(feature.style.strokeColor, OpenLayers.Feature.Vector.style['select'].strokeColor, "feature style is set to select style");
+        control.unselect(feature);
+        t.eq(feature.style.strokeColor, OpenLayers.Feature.Vector.style['default'].strokeColor, "feature style is set back to old style");
-    }
-