Changeset 5347

Timestamp:

12/05/07 03:53:27 (1 year ago)

Author:

tschaub

Message:

remove geometry components backwards - thanks for the catch flixo and review crschmidt (closes #1190).

Files:

• trunk/openlayers/lib/OpenLayers/Geometry/Collection.js (modified) (1 diff)
• trunk/openlayers/tests/Geometry/test_Collection.html (modified) (2 diffs)

trunk/openlayers/lib/OpenLayers/Geometry/Collection.js

@@ -178 +178 @@
-            components = [components];
-        }
- (var i = 0; i < components.length; i++
+(var i=components.length-1; i>=0; --i
-            this.removeComponent(components[i]);
-        }

trunk/openlayers/tests/Geometry/test_Collection.html

@@ -90 +90 @@
-
-    function test_04_Collection_removeComponents (t) {
-4
+5
-        coll = new OpenLayers.Geometry.Collection();
-        point = new OpenLayers.Geometry.Point(0,0);
@@ -101 +101 @@
-        t.eq( bounds.left, 10, "left bound is 10 after removeComponent" );
-        t.eq( bounds.bottom, 10, "bottom bound is 10 after removeComponent" );
+        
+        coll = new OpenLayers.Geometry.Collection();
+        for(var i=0; i<5; ++i) {
+            coll.addComponents(
+                new OpenLayers.Geometry.Point(Math.random(), Math.random())
+            );
+        }
+        coll.removeComponents(coll.components);
+        t.eq(coll.components.length, 0,
+             "remove components even works with multiple components");
+        
-    }
-