Changeset 5371

Timestamp:

12/11/07 02:27:45 (1 year ago)

Author:

crschmidt

Message:

MousePosition control throws error when no layers are on map. Fix it so that
they don't. Thanks for the review, fredj. Includes tests. (Closes #1029)

Files:

• trunk/openlayers/lib/OpenLayers/Control/MousePosition.js (modified) (1 diff)
• trunk/openlayers/tests/Control/test_MousePosition.html (modified) (1 diff)

trunk/openlayers/lib/OpenLayers/Control/MousePosition.js

@@ -109 +109 @@
-
-            lonLat = this.map.getLonLatFromPixel(evt.xy);
+            if (!lonLat) { 
+                // map has not yet been properly initialized
+                return;
+            }    
-            this.lastXy = evt.xy;
-        }

trunk/openlayers/tests/Control/test_MousePosition.html

@@ -38 +38 @@
-    }
-
+    function test_02_Control_MousePosition_redraw_noLayer_displayProjection(t) {
+        t.plan(3);
+        control = new OpenLayers.Control.MousePosition();
+        map = new OpenLayers.Map('map');
+        map.addControl(control);
+        t.eq(control.div.innerHTML, "0.00000, 0.00000", "innerHTML set correctly");
+        control.redraw({'xy': new OpenLayers.Pixel(10,10)});
+        control.redraw({'xy': new OpenLayers.Pixel(12,12)});
+        t.eq(control.div.innerHTML, "0.00000, 0.00000", "innerHTML set correctly");
+        l = new OpenLayers.Layer('name', {'isBaseLayer': true});
+        map.addLayer(l);
+        map.zoomToMaxExtent();
+        control.redraw({'xy': new OpenLayers.Pixel(10,10)});
+        control.redraw({'xy': new OpenLayers.Pixel(12,12)});
+        t.eq(control.div.innerHTML, "-175.78125, 85.78125", "innerHTML set correctly when triggered.");
+    }
+
-  </script>
-</head>