Changeset 5504

Timestamp:

12/18/07 20:33:20 (1 year ago)

Author:

crschmidt

Message:

Allow the use of custom GMapTypes via the Layer.Google. When passed a type in
the Layer.Google constructor, we check if the type we are given is not in the
map's list of types, and if so, add it. (Closes #1082)
r=tschaub

Files:

• trunk/openlayers/lib/OpenLayers/Layer/Google.js (modified) (1 diff)
• trunk/openlayers/tests/Layer/test_Google.html (modified) (1 diff)

trunk/openlayers/lib/OpenLayers/Layer/Google.js

@@ -160 +160 @@
-    setMapType: function() {
-        if (this.mapObject.getCenter() != null) {
+            
+            // Support for custom map types.
+            if (OpenLayers.Util.indexOf(this.mapObject.getMapTypes(),
+                                        this.type) == -1) {
+                this.mapObject.addMapType(this.type);
+            }    
+
-            this.mapObject.setMapType(this.type);
-            this.map.events.unregister("moveend", this, this.setMapType);

trunk/openlayers/tests/Layer/test_Google.html

@@ -86 +86 @@
-    }
-
+    function test_Layer_Google_setMapType (t) {
+        if (validkey) {
+            t.plan(3);
+            var layer = new OpenLayers.Layer.Google('Goog Layer');
+            layer.map = {'events':{'unregister': function() {}}};
+            layer.loadMapObject();
+            layer.mapObject.getCenter= function()  { return true; }
+            layer.mapObject.getMapTypes = function() { return [0, 1]; }
+            layer.mapObject.addMapType = function(type) {
+                t.eq(type, 5, "new map type passed correctly.");
+            }
+            layer.mapObject.setMapType = function(arg) { 
+               t.eq(arg, 5, "got map type"); 
+            }
+            layer.type = 5;
+            layer.setMapType();
+            layer.mapObject.setMapType = function(arg) { 
+               t.eq(arg, 0, "got map type"); 
+            }
+            layer.type = 0
+            layer.setMapType();
+            
+        } else {
+            t.plan(0);
+            t.debug_print("Google tests can't be run from " +
+                          window.location.host);
+        }
+    }
+
-    function test_04_Layer_Google_Translation_pixel (t) {
-        if(validkey) {