Changeset 6475

Timestamp:

03/10/08 14:23:19 (10 months ago)

Author:

euzuro

Message:

instead of directly modifyinG the popup's 'anchor' property each time the popup chanGes relative position, we instead override the calculateNewPx() function and adjust for the relative positions' offsets there. clean and simple (and took me all day on friday to fiGure it out :-P. Also in this commit, we update the offsets in the framedCloud example to be universal -- previously they were takinG into account the size of the marker in the example. also, we specify the correct information for the anchor in the sundials example. the framedpopup now works perfectly with any size or offset of anchor. one small step...

Files:

• sandbox/euzuro/pop/examples/sundials.html (modified) (1 diff)
• sandbox/euzuro/pop/lib/OpenLayers/Popup/Framed.js (modified) (3 diffs)
• sandbox/euzuro/pop/lib/OpenLayers/Popup/FramedCloud.js (modified) (4 diffs)

sandbox/euzuro/pop/examples/sundials.html

@@ -43 +43 @@
-        function onFeatureSelect(feature) {
-            selectedFeature = feature;
+            var anchor = {
+                'size': new OpenLayers.Size(0,0), 
+                'offset': new OpenLayers.Pixel(0,16)
+            };
-            popup = new OpenLayers.Popup.FramedCloud("chicken", 
-                                     feature.geometry.getBounds().getCenterLonLat(),
-                                     new OpenLayers.Size(100,100),
-                                     "<div style='font-size:.8em'>"+feature.attributes.description+"</div>",
-{'size': new OpenLayers.Size(0,0), 'offset': new OpenLayers.Size(0,0)}
-            
+anchor
+           
-            map.addPopup(popup);
-        }

sandbox/euzuro/pop/lib/OpenLayers/Popup/Framed.js

@@ -89 +89 @@
-                        closeBoxCallback) {
-
-
+
+
-        if (this.fixedRelativePosition) {
-            //based on our decided relativePostion, set the current padding
-            // this keeps us from getting into trouble 
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
-
-        this.contentDiv.style.position = "absolute";
@@ -239 +229 @@
-     */
-    updateRelativePosition: function(relativePosition) {
-        //update the anchor offset
-        this.anchor.offset = this.positionBlocks[relativePosition].offset;
-        
-        //update the padding
@@ -250 +238 @@
-            this.closeDiv.style.top = this.padding.top + "px";
-        }        
+    },
+
+    /** 
+     * Method: calculateNewPx
+     * 
+     * Parameters:
+     * px - {<OpenLayers.Pixel>}
+     * 
+     * Returns:
+     * {<OpenLayers.Pixel>} The the new px position of the popup on the screen
+     *     relative to the passed-in px.
+     */
+    calculateNewPx:function(px) {
+        var newPx = OpenLayers.Popup.Anchored.prototype.calculateNewPx.apply(
+            this, arguments
+        );
+                                                                    
+        newPx = newPx.offset(this.positionBlocks[this.relativePosition].offset);
+
+        return newPx;   
-    },
-

sandbox/euzuro/pop/lib/OpenLayers/Popup/FramedCloud.js

@@ -54 +54 @@
-    positionBlocks: {
-        "tl": {
-55, -10
+61, 15
-            'padding': new OpenLayers.Bounds(15, 75, 60, 15),
-            'blocks': [
@@ -80 +80 @@
-        },
-        "tr": {
-35, -10
+45, 15
-            'padding': new OpenLayers.Bounds(15, 75, 60, 15),
-            'blocks': [
@@ -111 +111 @@
-        },
-        "bl": {
-55, 0
+61, -6
-            'padding': new OpenLayers.Bounds(15, 45, 60, 53),
-            'blocks': [
@@ -142 +142 @@
-        },
-        "br": {
-35, 0
+44, -6
-            'padding': new OpenLayers.Bounds(15, 45, 60, 53),
-            'blocks': [