Changeset 6650

Timestamp:

03/28/08 00:29:40 (10 months ago)

Author:

euzuro

Message:

no need to override and recalculate the relative position in the draw() function. the problem here is that we need to know the relative position for the setSize() function (in order to properly calculate the position-dependent padding). instead of calculating it all over the place, we should only calculate it where it really makes sense: in moveTo(). the solution, then, is calling the moveTo() *before* calling setSize(). not really really a problem though, since the anchored class automatically re-moveTo()s a popup after it has been resized. problem solved.

Files:

• sandbox/euzuro/pop/lib/OpenLayers/Popup.js (modified) (2 diffs)
• sandbox/euzuro/pop/lib/OpenLayers/Popup/Anchored.js (modified) (1 diff)

sandbox/euzuro/pop/lib/OpenLayers/Popup.js

@@ -281 +281 @@
-        }
-
+        this.moveTo(px);
-        if (!this.autoSize) {
-            this.setSize(this.size);
@@ -288 +289 @@
-        this.setBorder();
-        this.setContentHTML();
-        this.moveTo(px);
-        
-        if (this.panMapIfOutOfView) {

sandbox/euzuro/pop/lib/OpenLayers/Popup/Anchored.js

@@ -100 +100 @@
-        OpenLayers.Popup.prototype.moveTo.apply(this, newArguments);
-    },
-    
-    /** 
-     * Method: draw
-     * 
-     * Parameters:
-     * px - {<OpenLayers.Pixel>}
-     * 
-     * Returns: 
-     * {DOMElement} Reference to a div that contains the drawn popup.
-     */
-    draw: function(px) {
-        if (px == null) {
-            if ((this.lonlat != null) && (this.map != null)) {
-                px = this.map.getLayerPxFromLonLat(this.lonlat);
-            }
-        }
-        
-        //calculate relative position
-        this.relativePosition = this.calculateRelativePosition(px);
-        
-        return OpenLayers.Popup.prototype.draw.apply(this, [px]);
-    },
-
-
-    /**