Changeset 7015

Timestamp:

04/27/08 00:14:50 (4 months ago)

Author:

crschmidt

Message:

Layer.GeoRSS should store the title and description attributes on the
created OpenLayers.Feature object for later access by applications.
Patch, including tests, written by Ian Mayo, r=me. (Closes #1485)

Files:

• trunk/openlayers/lib/OpenLayers/Layer/GeoRSS.js (modified) (1 diff)
• trunk/openlayers/tests/Layer/GeoRSS.html (modified) (2 diffs)

trunk/openlayers/lib/OpenLayers/Layer/GeoRSS.js

@@ -191 +191 @@
-            
-            if (title || description) {
+                // we have supplemental data, store them.
+                data.title = title;
+                data.description = description;
+            
-                var contentHTML = '<div class="olLayerGeoRSSClose">[x]</div>'; 
-                contentHTML += '<div class="olLayerGeoRSSTitle">';

trunk/openlayers/tests/Layer/GeoRSS.html

@@ -17 +17 @@
-
-    function test_Layer_GeoRSS_constructor (t) {
-5
+7
-        layer = new OpenLayers.Layer.GeoRSS('Test Layer', georss_txt );
-        t.ok( layer instanceof OpenLayers.Layer.GeoRSS, "new OpenLayers.Layer.GeoRSS returns object" );
@@ -26 +26 @@
-            t.eq( layer.markers.length, 40, "marker length is correct" );
-            var ll = new OpenLayers.LonLat(-71.142197, 42.405696);
+            var theTitle = "Knitting Room";
+            var theDescription = 'This little shop is jammed full. Yarn, yarn everywhere. They make the most of every possible nook and cranny. I like this place also because they have a lot of different kinds of knitting needles in all different sizes. Also, the people who work here are younger and hipper than in the other stores I go to. I reccomend buying supplies here and then knitting your way through a good documentary at the Capitol Theater across the street.<br/>Address: 2 lake St, Arlington, MA <br/>Tags: knitting, yarn, pins and needles, handspun, hand dyed, novelty yarn, fancy, simple, young, hip, friendly, needles, addy, cute hats<br /><br /><a href="http://platial.com/place/90306">Map this on Platial</a><br /> <a href="http://platial.com/place_grab/90306">Grab this on Platial</a> ';
-            t.ok( layer.markers[0].lonlat.equals(ll), "lonlat on first marker is correct" );
-            t.eq( layer.name, "Crschmidt's Places At Platial", "Layer name is correct." );
+            t.eq( layer.features[0].data.title, theTitle);
+            t.eq( layer.features[0].data.description, theDescription);
-        } );
-    }