OpenLayers OpenLayers

Changeset 7252

Show
Ignore:
Timestamp:
05/22/08 08:42:23 (4 months ago)
Author:
elemoine
Message:

geometry-less vector features aren't cloneable, r=pspencer (closes #1557)

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/openlayers/lib/OpenLayers/Feature/Vector.js

    r6240 r7252  
    8181                                                      [null, null, attributes]); 
    8282        this.lonlat = null; 
    83         this.geometry = geometry; 
     83        this.geometry = geometry ? geometry : null; 
    8484        this.state = null; 
    8585        this.attributes = {}; 
    …… 
    114114     */ 
    115115    clone: function () { 
    116         return new OpenLayers.Feature.Vector(this.geometry.clone(), 
    117                                              this.attributes, 
    118                                              this.style); 
     116        return new OpenLayers.Feature.Vector( 
     117            this.geometry ? this.geometry.clone() : null, 
     118            this.attributes, 
     119            this.style); 
    119120    }, 
    120121 

  • trunk/openlayers/tests/Feature/Vector.html

    r6719 r7252  
    6060     
    6161    function test_Feature_Vector_clone(t) { 
    62         t.plan(5); 
     62        t.plan(6); 
    6363 
    6464        var geometry = new OpenLayers.Geometry.Point(Math.random(), 
    …… 
    8080        t.eq(clone.geometry.y, geometry.y, 
    8181             "geometry.y property set properly"); 
     82 
     83        feature = new OpenLayers.Feature.Vector(); 
     84        clone = feature.clone(); 
     85        t.ok(clone instanceof OpenLayers.Feature.Vector, 
     86             "clone can clone geometry-less features"); 
    8287    } 
    8388