Changeset 7542

Timestamp:

07/18/08 03:18:27 (2 months ago)

Author:

pgiraud

Message:

we forgot to take Geometry.Collection into account when erasing geometries, r=elemoine (Closes #1621)

Files:

• trunk/openlayers/lib/OpenLayers/Renderer/Elements.js (modified) (1 diff)
• trunk/openlayers/tests/Renderer/Elements.html (modified) (2 diffs)

trunk/openlayers/lib/OpenLayers/Renderer/Elements.js

@@ -333 +333 @@
-        if ((geometry.CLASS_NAME == "OpenLayers.Geometry.MultiPoint") ||
-            (geometry.CLASS_NAME == "OpenLayers.Geometry.MultiLineString") ||
-
+
+
-            for (var i = 0; i < geometry.components.length; i++) {
-                this.eraseGeometry(geometry.components[i]);

trunk/openlayers/tests/Renderer/Elements.html

@@ -309 +309 @@
-    
-    function test_Elements_erasegeometry(t) {
-4
+5
-        
-        var el = document.createElement('div');
@@ -359 +359 @@
-        OpenLayers.Renderer.Elements.prototype.eraseGeometry(geometry);
-        t.ok(el.parentNode != document.body, "geometry components correctly removed when passed a multipolygon");
+        
+        var el = document.createElement('div');
+        document.body.appendChild(el);
+        el.id = 'bar';
+        var geometry = {
+            CLASS_NAME: "OpenLayers.Geometry.Collection",
+            components: [{
+                id: 'bar'
+            }]
+        };
+        
+        OpenLayers.Renderer.Elements.prototype.eraseGeometry(geometry);
+        t.ok(el.parentNode != document.body, "geometry components correctly removed when passed a collection");
-    }    
-