OpenLayers OpenLayers

Ticket #1013 (closed bug: fixed)

Opened 1 year ago

Last modified 11 months ago

OpenLayers.Layer.WMS.Untiled does not implement clone()

Reported by: openlayers Assigned to: euzuro
Priority: minor Milestone: 2.5 Release
Component: Layer.WMS Version: 2.5 RC3
Keywords: Cc:
State:

Description

Calling clone() on an OpenLayers.Layer.WMS.Untiled layer should return an Untiled instance. Instead, since it does not implement clone(), it returns a WMS instance.

Attachments

clone.patch (1.6 kB) - added by euzuro on 09/24/07 20:23:25.
clone.2.patch (3.5 kB) - added by euzuro on 09/25/07 03:48:49.
new patch includes fix and test for deprecated untiled mapserver layer.

Change History

09/24/07 20:23:25 changed by euzuro

  • attachment clone.patch added.

09/24/07 20:23:52 changed by euzuro

  • keywords changed from WMS Untiled clone to review.
  • milestone set to 2.5 Release.

tests pass ff/ie6. please review

09/25/07 03:48:49 changed by euzuro

  • attachment clone.2.patch added.

new patch includes fix and test for deprecated untiled mapserver layer.

09/25/07 03:51:39 changed by euzuro

new patch fixes mapserver's old untiled layer's clone. tests probably pass in ie6/ff but i can only speculate since the wifi in the quality inn victoria is comparable to my gait at the moment.

whoever can run tests please proceed accordingly.

09/30/07 12:19:11 changed by crschmidt

  • keywords changed from review to commit.

Ran the tests on it. It looks good. Please commit (and mark pullup)

10/02/07 21:39:21 changed by euzuro

(In [4761]) Even though we're deprecating them, we can't go back. WMS.Untiled and MapServer.Untiled both need to be able to clone correctly. Patch with tests. (See #1013)

10/02/07 21:39:52 changed by euzuro

  • keywords changed from commit to pullup.

10/03/07 16:27:17 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

(In [4794]) Pull up most of the changes for what will be 2.5RC4:

  • Clone on WMS/MS Untiled, 4760:4761 (Closes #1013)
  • serviceVersion on TMS, 4720:4721 (Closes #1023)
  • W3CGeo in Format.GeoRSS, 4768:4769, 4778:4779 (Closes #1024)
  • GeoJSON Draft4 Update, 4769:4770 (Closes #1028)
  • pagePosition Regression 4782:4783, (Closes #1034)
  • example changes 4691:4692 (Closes #1040)
  • WFS missing registerTileListener 4759:4760 (Closes #1045)
  • Yahoo API to stop dragging 4792:4793 (Closes #1052)