OpenLayers OpenLayers

Ticket #1016 (closed bug: duplicate)

Opened 1 year ago

Last modified 1 month ago

Layerselector has incorrect style for IE6.

Reported by: johnwebbcole Assigned to: euzuro
Priority: minor Milestone: 2.8 Release
Component: Control.LayerSwitcher Version: 2.4
Keywords: IE6 padding Cc:
State:

Description

The padding set on the layer selector can cause it to be rendered incorrectly on IE6. The examples do not show this, but when put deeper into div tags, it is rendered wrong. I have seen this mainly with Asp.Net using MasterPages.

I'm attaching a patch and example images.

Attachments

CropperCapture[6].Png (39.7 kB) - added by johnwebbcole on 09/25/07 08:49:03.
image of layer selector with padding in IE6
CropperCapture[7].Png (43.8 kB) - added by johnwebbcole on 09/25/07 08:49:31.
LayerSelector without padding in IE6
ie6_layerselector.patch (0.7 kB) - added by johnwebbcole on 09/25/07 08:50:38.
patch for OL 2.4

Change History

09/25/07 08:49:03 changed by johnwebbcole

  • attachment CropperCapture[6].Png added.

image of layer selector with padding in IE6

09/25/07 08:49:31 changed by johnwebbcole

  • attachment CropperCapture[7].Png added.

LayerSelector without padding in IE6

09/25/07 08:50:38 changed by johnwebbcole

  • attachment ie6_layerselector.patch added.

patch for OL 2.4

09/25/07 08:57:21 changed by johnwebbcole

Looking at the svn trunk, this patch should be applied there as well. I've tested this on IE6, IE7, FF2, Safari/Win and it appears to work on all of these browsers.

10/03/07 18:17:21 changed by euzuro

  • milestone set to 2.6 Release.

John, this looks like it might be a good fix. Can you point us to an HTML example that causes this css funkiness to occur?

That would help a lot with the review.

Since this is a purely visual fix, we will want an "acceptance example" for this, since testAnotherWay is not going to catch it.

(follow-up: ↓ 5 ) 10/04/07 07:44:12 changed by johnwebbcole

Erik,

I've patched all of my public systems, but I'll try and put up a sample site. I suspect that it has something to do with using master pages in ASP.Net.

01/22/08 17:41:15 changed by crschmidt

  • state changed.
  • milestone changed from 2.6 Release to 2.7 Release.

Mass ticket move to 2.7 post dev meeting. If you are actively working on this task, please update this ticket with information and change the milestone to 2.6. At the time of the next IRC meeting (most likely 1-31-08), this will mean the ticket can *not* be brought back into 2.6 unless there is further feedback.

(in reply to: ↑ 3 ) 07/02/08 03:11:19 changed by euzuro

.... are you out there, 'johnwebbcole' ? got any examples of this? :-) e

Replying to johnwebbcole:

Erik, I've patched all of my public systems, but I'll try and put up a sample site. I suspect that it has something to do with using master pages in ASP.Net.

07/28/08 11:56:38 changed by crschmidt

  • milestone changed from 2.7 Release to 2.8 Release.

07/28/08 12:01:09 changed by crschmidt

  • status changed from new to closed.
  • resolution set to duplicate.

We currently are not interested in doing this directly this way: it should be done with CSS. Thank you for the patch, and sorry for the inconvenience: See #1632 for more info.