Remove clear() from Layer's moveTo()

Hi Erik,

this does not solve the flash problem in my testcase unfortanately:

http://openlayers.org/pipermail/users/attachments/20070921/87e98332/attachment.html

Do comment out the layer.grid[0][0] = null; line in the example since this will cause js errors.

It seems the clear in moveTo is causing this, but we need this one since when zooming in you don't want the old image to be there, only when the extent does not change IMHO.

Any ideas?

Bart

I added a check for a change of bounds in the moveTo of Tile.js which works for me:

moveTo: function (bounds, position, redraw) {

if (redraw == null) {

redraw = true;

} if (!this.bounds.equals(bounds)) {

this.clear();

} this.bounds = bounds.clone(); this.position = position.clone(); if (redraw) {

this.draw();

}

},

So when zooming, the tile will be cleared, when you are running something like a WMS timeseries with a timer, the bounds will not change, and the map will not flash.

This patch is the first part of the flashing bug solution. Erik and Paul are working on the other part, so I'll mark this ready to commit.

Replying to openlayers:

I added a check for a change of bounds in the moveTo of Tile.js which works for me: moveTo: function (bounds, position, redraw) { if (redraw == null) { redraw = true; } if (!this.bounds.equals(bounds)) { this.clear(); } this.bounds = bounds.clone(); this.position = position.clone(); if (redraw) { this.draw(); } }, So when zooming, the tile will be cleared, when you are running something like a WMS timeseries with a timer, the bounds will not change, and the map will not flash.

Hi Bart, I can't *quite* see what you're trying to get at with this, but I think it's a different problem. This ticket is not supposed to solve the flash problem, though it is a step in the right direction.

It looks like we'll be working on this a bit today with Paul, so let's see where we can go with it.

-E

(In [4502]) Fix to remove extraneous clear() from Tile.moveTo (Closes #1017)