OpenLayers OpenLayers

Ticket #103 (closed feature: fixed)

Opened 4 years ago

Last modified 3 years ago

attribution and copyright field

Reported by: anonymous & jrf Assigned to: euzuro
Priority: major Milestone: 2.5 Release
Component: Map Version:
Keywords: Cc: penyaskito@gmail.com
State:

Description (Last modified by jrf)

To make it easy for proprietary data licensees to present the data they have bought in OpenLayers.Layer directly, e.g. by using the WMS layer or an adaptation of that to their own tiling scheme, we need to add methods of obeying the attribution and copyright requirements of these data sources. Typically a line of text at the bottom of the map window is sufficient.

Since maps contain many layers, the attribution text must be able to handle additions from many layers -- gracefully! The attribution text should also allow HTML so that it can contain hyperlinks, bolding, © etc.

A key requirement for most of the data providers that require attribution text is that it be visible when someone takes a screenshot. That means that the attribution text can disappear when data from that layer is not visible.

Attachments

Attribution.patch (5.3 kB) - added by openlayers on 04/07/07 10:50:08.
A patch for adding the copyright text to each layer
103.patch (7.4 kB) - added by crschmidt on 09/11/07 23:03:46.
103.2.patch (7.6 kB) - added by euzuro on 09/11/07 23:33:49.
coding standards, adding some documentation bits and also rearranging the functions in the new control. no functional diff. you like?
103.3.patch (3.2 kB) - added by crschmidt on 09/12/07 06:20:49.

Change History

08/15/06 22:55:43 changed by euzuro

  • milestone deleted.

03/09/07 16:18:33 changed by sderle

  • milestone set to 2.5 Release.

04/07/07 10:50:08 changed by openlayers

  • attachment Attribution.patch added.

A patch for adding the copyright text to each layer

04/07/07 11:28:16 changed by openlayers

  • cc set to penyaskito@gmail.com.
  • keywords set to review.

05/13/07 08:36:01 changed by jrf

  • description changed.
  • reporter changed from anonymous to anonymous & jrf.

05/23/07 23:45:54 changed by crschmidt

  • owner changed from sderle to metacarta.
  • priority changed from blocker to major.

06/29/07 08:04:57 changed by crschmidt

Erik --

Can you look at http://openlayers.org/pipermail/dev/2007-May/000705.html , which is blocking this, and let me know if this event can be dropped?

08/27/07 11:10:39 changed by crschmidt

  • owner changed from metacarta to euzuro.

09/11/07 23:03:46 changed by crschmidt

  • attachment 103.patch added.

09/11/07 23:33:49 changed by euzuro

  • attachment 103.2.patch added.

coding standards, adding some documentation bits and also rearranging the functions in the new control. no functional diff. you like?

09/11/07 23:37:48 changed by euzuro

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

(In [4231]) adding OpenLayers.Control.Attribution to the list of controls in the OL suite. includes example and tests. very nice. Thanks to pensyakito and cr5 for getting this together and complete. (Closes #103)

09/12/07 03:25:02 changed by fredj

  • status changed from closed to reopened.
  • resolution deleted.

http://www.openlayers.org/dev/examples/attribution.html don't work for me.

On page load the attribution is correctly set but when I change the base layer with the layer switcher, the attribution is empty.

FF 2.0.0.6 on Linux

in source:trunk/openlayers/lib/OpenLayers/Control/Attribution.js line 69, layer.getVisibility() always return false (race condition ?)

09/12/07 05:39:51 changed by fredj

and replace 'seperator' with 'separator'

09/12/07 06:20:49 changed by crschmidt

  • attachment 103.3.patch added.

09/12/07 06:21:47 changed by crschmidt

  • keywords set to review.

fredj: nice catch.

Attached patch does both of these:

1. register for changebaselayer, since changelayer is only called in setBaseLayer *before* the layer has actually changed.

2. Fix speling. (That was intentional.)

09/12/07 08:40:29 changed by crschmidt

  • keywords deleted.
  • status changed from reopened to closed.
  • resolution set to fixed.

(In [4237]) FredJ reviewed my work here and said it solved the problem that he reopened 103 for (specifically, that baselayer changes always resulted in a null attribution string), and fixes spelling. This commit makes the attribution control work and stuff. (Closes #103)