OpenLayers OpenLayers

Ticket #1042 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

renderer flashes black

Reported by: tschaub Assigned to: tschaub
Priority: minor Milestone: 2.6 Release
Component: Renderer Version: 2.5
Keywords: Cc:
State:

Description

when modifying drawn features, the renderer flashes black before drawing the feature with the correct style.

Attachments

render.patch (2.4 kB) - added by crschmidt on 10/02/07 19:52:16.
renderer.2.patch (3.3 kB) - added by pgiraud on 10/24/07 10:04:34.
same patch as crschmidt but with changes also for vml
renderer.patch (4.5 kB) - added by tschaub on 11/09/07 11:35:16.
stop flashing black and filling white

Change History

09/30/07 21:20:04 changed by tschaub

  • keywords set to review.
  • owner set to tschaub.
  • status changed from new to assigned.

tests anyone?

10/02/07 12:04:44 changed by bphilippot

The patch is ok with the drawFeatures example but with vector-features example, firebug displays the following error : Node was not found" code: "8. I'm looking too for an other solution but no results for the moment

10/02/07 19:51:45 changed by crschmidt

  • keywords deleted.
  • milestone changed from 2.5 Release to 2.6 Release.

The setStyle function in SVG.js attempts to remove the point node from the renderer (which it has not been added to yet), because in the case of an externalGraphic, it needs to change the element type from 'point' to 'image'.

I think this means that in order to make this work, a relatively complex reworking of the renderer functionality would be needed, and I'm not willing to let that go into an RC this late in the game. If we decide that we have something we like early into 2.6, we can observe use cases to ensure that we haven't broken anything, and then either pull it back to the 2.5 branch, or release an override addon to let people have it in 2.5.

Uploading the patch which makes vector-features work for me.

10/02/07 19:52:16 changed by crschmidt

  • attachment render.patch added.

10/03/07 05:37:25 changed by bphilippot

The patch works well with Firefox but there are some errors with IE. After removing console.log in Elements.js and editing the setStyle function in VML.js in the same way as in SVG.js, a frame appears around the marker in vector-features.html and an error still occures when the draw-feature.html page is closed.

So, flashes have disappeared with Firefox but there are still there with IE.

10/03/07 07:51:45 changed by crschmidt

There is always a frame around the marker in vector-features :) (It's there in trunk, too.)

10/24/07 10:04:34 changed by pgiraud

  • attachment renderer.2.patch added.

same patch as crschmidt but with changes also for vml

10/24/07 10:16:06 changed by pgiraud

The proposed patch modifies VML renderer to match the SVG proposed changes. While this seem to work for the vector-features.html example, IE raises an error when closing the draw-feature.html page.

10/24/07 12:07:55 changed by pgiraud

The error raised is more certainly due to bug explained in #1107.

10/25/07 03:27:32 changed by pgiraud

  • keywords set to review.
  • version changed from 2.5 RC3 to 2.5.

All tests pass on IE6 win and FF linux. Side note : we have no significant tests for renderers.

11/09/07 11:22:50 changed by tschaub

  • keywords deleted.

Ok, this is really pretty on FF, but it leaves white fill between end nodes of a line.

11/09/07 11:25:04 changed by tschaub

sorry, yes, on IE

11/09/07 11:35:16 changed by tschaub

  • attachment renderer.patch added.

stop flashing black and filling white

11/09/07 11:36:28 changed by tschaub

  • keywords set to review.

Automated tests pass (of course), and more importantly manual acceptance tests pass (modify-features.html looks good in IE and FF).

Will gladly commit with approval.

11/09/07 11:36:50 changed by tschaub

I should mention that this patch includes the fix for #819.

11/09/07 12:12:14 changed by crschmidt

  • keywords changed from review to commit.

Looks good. Please commit.

11/09/07 12:14:13 changed by tschaub

  • keywords deleted.
  • status changed from assigned to closed.
  • resolution set to fixed.

(In [5158]) stop the renderers from flashing black and filling white - ahhh, much prettier vector drawing now - thanks to pgiraud and crschmidt (closes #1042).