OpenLayers OpenLayers

Ticket #1043 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

OpenLayers zooms in too far on an extent

Reported by: openlayers Assigned to:
Priority: minor Milestone: 2.5 Release
Component: Map Version: 2.5 RC3
Keywords: Cc:
State:

Description

For a given extent, OpenLayers 2.5rc3 occasionally zooms in too far.

Attachments

zoomer.patch (4.7 kB) - added by euzuro on 10/03/07 00:38:20.
first run of patch. all tests seem to be passing ie6/ff. Need to write some new tests still though.
zoomer.2.patch (4.2 kB) - added by euzuro on 10/03/07 00:44:58.
take two. no functionality changes, but removed the unnecessary stylie bits from Map.js diff and fixed up the ND comments in Layer.js Jeito, cara. Jeito.
zoomer.3.patch (5.1 kB) - added by euzuro on 10/03/07 01:22:29.
zoomer now has a few simple tests.
zoomer.TRUNK.patch (22.0 kB) - added by euzuro on 10/03/07 01:32:28.
This is everything from the zoomer.3.patch but for application to trunk. Basically the difference is that this patch includes the reverting of r4381
zoomer.TRUNK.2.patch (23.1 kB) - added by euzuro on 10/03/07 13:15:23.
new version of patch, adding r4787 to the mix
zoomer.TRUNK.3.patch (23.9 kB) - added by euzuro on 10/03/07 14:58:08.
adding the latest change to the sandbox from cr5: incorporating 'closest' into getZoomForExtent() on the Map
zoomer.TRUNK.4.patch (23.9 kB) - added by euzuro on 10/03/07 15:17:25.
just to be polite, this is the official patch that's going in. it's exactly the same as zoomer.TRUNK.3.patch but with r4791

Change History

10/01/07 16:49:04 changed by crschmidt

The new rounding code works great ... except if your desired extent is too close to a lower resolution. WE'll need to do something different here.

10/03/07 00:38:20 changed by euzuro

  • attachment zoomer.patch added.

first run of patch. all tests seem to be passing ie6/ff. Need to write some new tests still though.

10/03/07 00:44:58 changed by euzuro

  • attachment zoomer.2.patch added.

take two. no functionality changes, but removed the unnecessary stylie bits from Map.js diff and fixed up the ND comments in Layer.js Jeito, cara. Jeito.

10/03/07 01:22:29 changed by euzuro

  • attachment zoomer.3.patch added.

zoomer now has a few simple tests.

10/03/07 01:32:28 changed by euzuro

  • attachment zoomer.TRUNK.patch added.

This is everything from the zoomer.3.patch but for application to trunk. Basically the difference is that this patch includes the reverting of r4381

10/03/07 01:34:53 changed by euzuro

  • keywords set to review.

If anyone out there can point us to one of the example HTML files in which switching baselayers caused an unpleasant zoomin or zoomout (can't remember which)... or if anyone has their own HTML they'd like to try this on, can you please do so? This latest patch (zoomer.3.patch or zoomer.TRUNK.patch) I think *should* fix things but we need a good before test. The after test seems fine (zooming is back to functional ((you always see your whole zoom box)) but the switching baselayers is harder to test)

cheers.

please review.

(see the zoomer.3.patch for reviewing... zoomer.TRUNK.patch is for applying to trunk)

10/03/07 13:15:23 changed by euzuro

  • attachment zoomer.TRUNK.2.patch added.

new version of patch, adding r4787 to the mix

10/03/07 13:41:16 changed by euzuro

zoomer.TRUNK.2.patch applied to trunk passes all tests ie6/ff

10/03/07 14:58:08 changed by euzuro

  • attachment zoomer.TRUNK.3.patch added.

adding the latest change to the sandbox from cr5: incorporating 'closest' into getZoomForExtent() on the Map

10/03/07 15:08:06 changed by euzuro

tests pass in ie6

10/03/07 15:10:11 changed by crschmidt

  • keywords changed from review to commit.

tests pass in IE7, FF.

I've manually tested all the cases that I can find, and I think that this is going to provide a better fit for us. It's possible that Tim is going to come along and wave a magic wand and we'll all change the way we do things -- but the goal for 2.5 was to fix the baselayer change zooms, which I can confirm this does.

We can revisit in 2.6 to figure out if we should change more than that.

Go ahead to commit.

10/03/07 15:17:25 changed by euzuro

  • attachment zoomer.TRUNK.4.patch added.

just to be polite, this is the official patch that's going in. it's exactly the same as zoomer.TRUNK.3.patch but with r4791

10/03/07 15:24:48 changed by euzuro

  • keywords changed from commit to pullup.

thanks chris for help reviewing and improving this patch.

10/03/07 16:42:39 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

(In [4795]) Pullup fix for zooms to branch. (Closes #1043) 4791:4792