OpenLayers OpenLayers

Ticket #1044 (closed feature: fixed)

Opened 1 year ago

Last modified 1 year ago

KML should automatically determine NS

Reported by: crschmidt Assigned to: tschaub
Priority: minor Milestone: 2.5 Release
Component: Format.KML Version: 2.5 RC3
Keywords: Cc:
State:

Description

With three different KML namespaces floating about, the KML layer should have support for automatically determining the KML namespace version in use.

If we don't do this, I forsee a lot of problems as more users start using the KML layer.

Attachments

kml_ns.patch (4.5 kB) - added by crschmidt on 10/02/07 20:11:30.

Change History

10/02/07 20:11:30 changed by crschmidt

  • attachment kml_ns.patch added.

10/02/07 20:12:58 changed by crschmidt

Search all nodes for Placemarks. once we have placemarks, store the namespaceURI from the node if it exists, and use that to parse the rest of the document.

The default namespace for output is still 2.0. All tests continue to pass, and new tests have been added.

10/02/07 20:13:13 changed by crschmidt

  • keywords set to review.

10/03/07 01:24:58 changed by sderle

  • keywords changed from review to commit.

This patch seems fine, but what if a user wants to set the kmlns manually in code? I don't see it as a blocker if they can't for now, so please commit.

10/03/07 17:13:32 changed by crschmidt

I can't imagine a way in which that would make sense. I'm going with this for 2.5RC4, and we can revisit later if it comes up again.

10/03/07 17:18:40 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

(In [4798]) Pullup for KML needs to automatically determine the namespace of the document it is handling. (Closes #1044)