OpenLayers OpenLayers

Ticket #1046 (closed task: fixed)

Opened 1 year ago

Last modified 1 year ago

Fix getZoomForResolution() on FixedZoomLevels

Reported by: euzuro Assigned to: euzuro
Priority: minor Milestone: 2.6 Release
Component: Layer.FixedZoomLevels Version: 2.5 RC3
Keywords: Cc:
State: Complete

Description

This line: 

            var extent = OpenLayers.Layer.prototype.getExtent.apply(this, 
                                                                    [resolution]);

doesn't make sense. getExtent() on Layer doesn't take any arguments.

Attachments

getExtentArgs.patch (0.8 kB) - added by euzuro on 10/03/07 18:36:22.
not sure whether this really merits a patch or not, but passing an unnecessary arg might confuse someone. keep it simple.

Change History

10/03/07 18:36:22 changed by euzuro

  • attachment getExtentArgs.patch added.

not sure whether this really merits a patch or not, but passing an unnecessary arg might confuse someone. keep it simple.

10/03/07 18:50:06 changed by euzuro

  • keywords set to review.

tests pass ie6/ff. please review

10/06/07 12:41:51 changed by crschmidt

Can't you just do:

apply(this)

and skip the arguments? or does that not work?

10/08/07 17:19:00 changed by euzuro

it works on FF but not on IE. :-(

12/15/07 11:32:33 changed by crschmidt

  • status changed from new to closed.
  • state changed from Review to Complete.
  • resolution set to fixed.

(In [5431]) Fix getZoomForResolution() on FixedZoomLevels, which is passed an extra (unused) argument. (Closes #1046)