OpenLayers OpenLayers

Ticket #1059 (closed task: fixed)

Opened 1 year ago

Last modified 1 year ago

Mark drawFeature(..) as stable

Reported by: openlayers Assigned to:
Priority: minor Milestone: 2.6 Release
Component: general Version: 2.5 RC4
Keywords: Cc:
State:

Description

I use the Vector layer's drawFeature(..) method. It seems to be working fine, so could you mark it as stable?

Cheers Nils

Attachments

drawFeature.patch (0.5 kB) - added by euzuro on 10/10/07 02:25:00.
simple patch to make the drawFeature() function on OpenLayers.Layer.Vector a public API function. no functional change.

Change History

10/10/07 01:23:53 changed by crschmidt

  • milestone set to 2.6 Release.

Tim, Erik, any negative feedback on this one?

(follow-up: ↓ 3 ) 10/10/07 02:23:56 changed by euzuro

Not really so much my territoire, but I know that Tim is busy for a while... maybe elemoine has an opinion?

My gut reaction is that since this function is called from other segments of the code (Handlers and Controls) and that it brings up 41 total matches on a grep in the lib directory... I'd say the function seems to be pretty enmeshed in the code. which is to say I don't think there's much risk to making it API. If others are building custom handlers and controls, they might understandably need it.

10/10/07 02:25:00 changed by euzuro

  • attachment drawFeature.patch added.

simple patch to make the drawFeature() function on OpenLayers.Layer.Vector a public API function. no functional change.

(in reply to: ↑ 2 ) 10/10/07 15:27:55 changed by elemoine

Replying to euzuro:

Not really so much my territoire, but I know that Tim is busy for a while... maybe elemoine has an opinion? My gut reaction is that since this function is called from other segments of the code (Handlers and Controls) and that it brings up 41 total matches on a grep in the lib directory... I'd say the function seems to be pretty enmeshed in the code. which is to say I don't think there's much risk to making it API. If others are building custom handlers and controls, they might understandably need it.

Yeah, I think drawFeature is a good candidate for being a public API method. Actually, I'm pretty sure I've used in all the OpenLayers projects I've worked on up to now :-)

11/21/07 15:31:16 changed by crschmidt

  • status changed from new to closed.
  • resolution set to fixed.

(In [5244]) Mark drawFeature as stable (Closes #1059)

11/22/07 04:32:05 changed by ahocevar

  • status changed from closed to reopened.
  • resolution deleted.

would reconsider that, especially since no one has obviously taken notice of my posting a few days ago (http://www.nabble.com/Features,-Styling-and-Rendering-t4823880.html).

After some discussion with Tim, I tried to figure out a way on how to work with kml style maps in the future. I came up with the idea that drawFeature have a style as second parameter, but a renderIntent, which would be the key of a style map. In the above posting I also discribed the advantages of this approach.

By marking drawFeature as stable, you are taking away the opportunity to get this done prior to 3.0.

11/22/07 08:23:42 changed by ahocevar

  • status changed from reopened to closed.
  • resolution set to fixed.

11/26/07 18:11:07 changed by tschaub

Sorry I didn't get to this earlier. I agree that it would unfortunate to be stuck with a function signature that would keep us from better handling styles. That said, if we do get better style stuff in, this method could take either a style object or style key (string) without breaking the api. I don't like the flexible argument type stuff so much - but it is an alternative if nobody else wants to change this before 2.6.