OpenLayers OpenLayers

Ticket #1062 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

geojson format breaks on CRS changes

Reported by: crschmidt Assigned to: tschaub
Priority: minor Milestone: 2.5 Release
Component: Format.GeoJSON Version: 2.5 RC4
Keywords: Cc:
State:

Description

GeoJSON CRS changes break GeoJSON format

Attachments

geojson.patch (1.9 kB) - added by crschmidt on 10/04/07 13:30:54.
geojson.2.patch (3.4 kB) - added by crschmidt on 10/04/07 13:39:32.
geojson.3.patch (3.3 kB) - added by crschmidt on 10/04/07 13:55:01.
patch not dependant on test ordering
geojson.4.patch (3.6 kB) - added by crschmidt on 10/04/07 14:08:16.
also update docs

Change History

10/04/07 13:30:54 changed by crschmidt

  • attachment geojson.patch added.

10/04/07 13:39:32 changed by crschmidt

  • attachment geojson.2.patch added.

10/04/07 13:40:09 changed by crschmidt

  • keywords set to review.

Second patch has tests.

10/04/07 13:41:00 changed by crschmidt

The reason this wasn't caught in testing is because the GeoJSON features being serialized didn't have layers. WIth no layers, there is in projection object, so the GeoJSON parser doesn't do any CRS anything. When you add a layer, it breaks. This patch fixes that, and adds tests to ensure it doesn't break again.

10/04/07 13:51:03 changed by crschmidt

Tests pass for me in IE6 and FF

10/04/07 13:55:01 changed by crschmidt

  • attachment geojson.3.patch added.

patch not dependant on test ordering

10/04/07 13:58:17 changed by crschmidt

IE7 ran tests differently ordered on me, so this patch doesn't depend on ordering. rerunning tests in FF, IE6, IE7 now

10/04/07 14:02:45 changed by crschmidt

Tests all passing in IE6, IE7, FF.

10/04/07 14:08:16 changed by crschmidt

  • attachment geojson.4.patch added.

also update docs

10/04/07 14:09:22 changed by euzuro

  • keywords changed from review to commit.

looks good. please insert, mark pullup, dance.

10/04/07 14:11:18 changed by crschmidt

  • keywords changed from commit to pullup.

(In [4819]) The createCRSObject stuff never really worked. Unfortunately, the tests didn't catch it because they were all minimal unit tests -- so they never hooked up features to layers with projections. This fixes the createCRSObject function, including updated documentation, and includes tests for regression. (Pullup #1062)

10/04/07 18:51:24 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

(In [4830]) Pullup r4819 from trunk: fixing GeoJSON serializer breakage caused by draft4 update. (Closes #1062)