OpenLayers OpenLayers

Ticket #1066 (reopened bug)

Opened 1 year ago

Last modified 1 week ago

feature overlays the others when selected

Reported by: pgiraud Assigned to:
Priority: minor Milestone: 2.8 Release
Component: Renderer.Elements Version: SVN
Keywords: Cc:
State: Complete

Description

When selected, a feature z-index (position in the DOM) changes and in some cases, user can't select the features below. drawFeature should keep the geometry node in place in the DOM. I propose we call appendChild only if this is a new node.

See proposed patch. I'm not proud of the isChild boolean, but node.childNodes doesn't provide a indexOf method.

Attachments

Renderer.Elements.patch (1.0 kB) - added by pgiraud on 10/05/07 17:58:32.
Renderer.Elements.2.patch (0.7 kB) - added by pgiraud on 10/25/07 11:05:59.
new patch integrating Chris suggestions
Renderer.Elements.3.patch (0.7 kB) - added by pgiraud on 01/15/08 03:51:27.
updated patch made against r5614

Change History

10/05/07 17:58:32 changed by pgiraud

  • attachment Renderer.Elements.patch added.

10/06/07 21:22:08 changed by crschmidt

I think this patch would likely introduce an unacceptable performance penalty.

Checking node.parentNode == root should accomplish the same thing, no?

10/25/07 11:05:59 changed by pgiraud

  • attachment Renderer.Elements.2.patch added.

new patch integrating Chris suggestions

12/15/07 13:54:34 changed by crschmidt

  • state set to Review.

12/20/07 16:00:04 changed by elemoine

I'm fine with this patch, as long as the select-feature.html still works and that the tests still pass. Pierre, can you check this and mark the patch as Commit once this is positively checked. Thanks.

01/15/08 03:51:27 changed by pgiraud

  • attachment Renderer.Elements.3.patch added.

updated patch made against r5614

01/15/08 03:54:33 changed by pgiraud

I updated the patch to match the new revision and changed (simplified) the comment doc. All tests pass under FF2 and IE6. Also, the manual tests on select-feature.html showed me that it still works.

Please review this one last time before it goes to trunk. Don't hesitate to change the comment, if you can propose something easier to understand.

01/15/08 15:28:26 changed by elemoine

  • state changed from Review to Commit.

01/16/08 03:40:22 changed by pgiraud

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [5772]) don't re-append the geometry node to root if it is already there to keep it in place and to prevent z-index to change, r=elemoine (closes #1066) Thanks Eric for giving me the opportunity to have my first commit in OpenLayers trunk

11/26/08 01:54:34 changed by pgiraud

  • status changed from closed to reopened.
  • type changed from feature to bug.
  • version changed from 2.5 RC5 to SVN.
  • resolution deleted.
  • milestone changed from 2.6 Release to 2.8 Release.

I think that there is a regression on that one, so I'm reopening it.