OpenLayers OpenLayers

Ticket #1068 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

When Navigation control is inactive, doubleclick zooms in

Reported by: crschmidt Assigned to:
Priority: minor Milestone: 2.6 Release
Component: Control.NavToolbar Version: 2.5 RC5
Keywords: Cc:
State: Complete

Description

The DoubleClick event in the Navigation control is registered directly on the map, and is not deregistered by deactivate. This means that with an inactive navigation control, double clicks on the map still zoom in.

Attachments

navigation_clickhandler.patch (1.7 kB) - added by crschmidt on 12/19/07 22:54:47.

Change History

10/06/07 10:54:46 changed by crschmidt

I think that one of the parts of this solution is to create a click/doubleclick handler, and use that to register the event instead.

12/15/07 17:02:20 changed by crschmidt

  • state changed.

#1211 is the click/doubleclick handler.

12/19/07 22:54:47 changed by crschmidt

  • attachment navigation_clickhandler.patch added.

12/19/07 22:56:02 changed by crschmidt

  • state set to Review.

Attached patch passes in FF, Safari. Assuming the click handler does what it's supposed to, this should work in IE, and solve the problem. I think. :) I've also tested it and see now ill effects on any demo I can think ot test.

12/19/07 23:09:37 changed by tschaub

  • state changed from Review to Commit.

Go click handler, go. Works well. Please commit.

12/19/07 23:11:52 changed by crschmidt

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [5527]) Fix for "When Navigation control is inactive, doubleclick zooms in", using the new click handler that Tim and I created over the weekend. (Hooray for handlers!) r=tschaub (Closes #1068)