OpenLayers OpenLayers

Ticket #1071 (new feature)

Opened 10 months ago

Last modified 6 days ago

selectfeature via draggable box

Reported by: crschmidt Assigned to:
Priority: minor Milestone: 2.7 Release
Component: Control Version: SVN
Keywords: Cc:
State: Review

Description

Add support to select multiple features via a draggable box, using the Handler.Box.

Attachments

selectfeature.patch (7.8 kB) - added by crschmidt on 10/06/07 12:09:54.
patch requires #1070 for styling support
patch-1071-r7546-A0.diff (13.3 kB) - added by pgiraud on 07/21/08 05:07:18.

Change History

10/06/07 12:09:54 changed by crschmidt

  • attachment selectfeature.patch added.

patch requires #1070 for styling support

10/06/07 12:10:44 changed by crschmidt

  • keywords set to review.

10/06/07 14:35:49 changed by tschaub

I agree this is needed.

I haven't thoroughly checked this out, but I'd like to before it goes in. The selection by intersecting bounds rubs me the wrong way. Point in poly and geometry intersection methods are not beyond what we can do here, and I'd like to give that a go before we commit to this. Also, I've always been annoyed by editing environments that ditch selected features when I'm trying to add new features to the selected bunch. Between shift, alt, and ctrl, we can have nice options for adding new features, removing from a selection, and selecting a fresh batch. I've implemented this elsewhere and it works nicely.

10/06/07 14:51:34 changed by crschmidt

I think that having an 'intersectsBounds' (or just 'intersects') operator on the geometry would be nice, but I don't think it should be a blocker for putting this functionality in, if it's slow in coming. I'm willing to wait if you're willing to put the legwork in.

How do you envision the different actions working? I couldn't figure out a way to get the actual used key mask from the Handler.Box -- I had considered creating several Handler.Box handlers for different things, but thought that 'shift-dragbox' was magical enough, and that I didn't want to go more complex than that. The intersectsBox property on the control was a workaround.

10/06/07 14:55:02 changed by crschmidt

  • keywords deleted.

removing review keyword pending further work on geometry.intersects() and inclusive vs. exclusive select handling.

12/19/07 23:50:32 changed by crschmidt

  • state changed.
  • milestone changed from 2.6 Release to 2.7 Release.

07/18/08 09:44:13 changed by pgiraud

I would like to give a second shot on this one. Any hints on what to start with ? Thanks.

07/21/08 05:07:18 changed by pgiraud

  • attachment patch-1071-r7546-A0.diff added.

07/21/08 05:08:28 changed by pgiraud

  • state set to Review.

Tests are OK (except MultiMap, and those recently broken See #1602)