OpenLayers OpenLayers

Ticket #1088 (closed bug: fixed)

Opened 11 months ago

Last modified 9 months ago

KML files with >4k coordinates fail in FF

Reported by: crschmidt Assigned to: tschaub
Priority: minor Milestone: 2.6 Release
Component: Format.KML Version: 2.5
Keywords: Cc:
State:

Description

KML files with coordinates elements with greater than 4k of data fail to load correctly in FF, sometimes throwing a "Bad LineString coordinate" exception.

r4410 fixed this for GML, copy that into KML.

Attachments

kml_fix.patch (0.7 kB) - added by openlayers on 11/16/07 21:00:23.
Here's a patch

Change History

11/16/07 20:39:31 changed by crschmidt

#1155 has example screenshots and KML.

11/16/07 21:00:23 changed by openlayers

  • attachment kml_fix.patch added.

Here's a patch

(follow-up: ↓ 3 ) 11/16/07 21:02:40 changed by crschmidt

  • keywords set to needstests.

Needs two tests before commiting: one to test less than 4k, one to test more than 4k.

(in reply to: ↑ 2 ) 11/16/07 21:33:15 changed by openlayers

Replying to crschmidt:

Needs two tests before commiting: one to test less than 4k, one to test more than 4k.

I'm not sure how to write tests that require one to "view" the results for correctness (if that's necessary?), but I can say that the distributed lines.kml file worked in Firefox before my change, and the lines.kml attached to bug 1155 didn't work. So 1155's line.kml is >4k, I guess, and the distributed lines.kml is < 4k. Sorry I can't help with this one more...

11/16/07 21:53:06 changed by crschmidt

No need to view them: instead, check feature.geometry.components.length (or similar -- if it's a poly, it'll be components[0].components.length, for example).

12/13/07 19:01:14 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

(In [5402]) Apply a fix to KML format to support > 4k characters in a linestring. (Closes #1088)