OpenLayers OpenLayers

Ticket #1112 (new bug)

Opened 10 months ago

Last modified 3 weeks ago

Only show Browser Incompatibility message Once

Reported by: euzuro Assigned to: tcoulter
Priority: critical Milestone: 2.7 Release
Component: Layer.Vector Version: 2.5
Keywords: Cc:
State: Needs More Work

Description

Right now we get that error message for every vector layer that's loaded, we should make it so that it only loads once.

Attachments

onlyOnce.patch (464 bytes) - added by euzuro on 07/04/08 03:09:15.
patch to make sure this error only reported once.

Change History

07/04/08 03:09:15 changed by euzuro

  • attachment onlyOnce.patch added.

patch to make sure this error only reported once.

07/04/08 03:10:20 changed by euzuro

  • state changed.
  • milestone set to 2.7 Release.

I don't know if people actually want this patch, but to me it seems nice. Especially in the case where user opens a file with *many* vector layers in an unfriendly browser, getting that message over and over again would be really annoying.

..maybe I'm overlooking something, though?

07/04/08 08:54:22 changed by pagameba

  • state set to Review.

I think this is a good change and the patch seems unlikely to break anything.

07/11/08 16:40:13 changed by elemoine

Does this patch really work and make the error message appear only on the first vector layer creation? It seems to be that doing this.reportError = false will only prevent getting the error message multiple times *per* vector layer, which is already the case since displayError() is called in the constructor only. Doing OpenLayers.Layer.Vector.prototype.reportError = false would look better to me.

07/11/08 16:40:24 changed by elemoine

  • state changed from Review to Needs More Work.

07/28/08 14:37:28 changed by euzuro

  • priority changed from minor to critical.

get rid of the alert as well.

08/01/08 22:47:19 changed by crschmidt

  • owner changed from crschmidt to tcoulter.