OpenLayers OpenLayers

Ticket #1128 (closed feature: fixed)

Opened 1 year ago

Last modified 1 year ago

there are no tests for the renderers

Reported by: pgiraud Assigned to:
Priority: minor Milestone: 2.6 Release
Component: tests Version: 2.5
Keywords: Cc:
State:

Attachments

renderers_tests.2.patch (30.1 kB) - added by pgiraud on 11/08/07 09:56:39.
tests for Renderer, Elements (almost complete), SVG
renderers_tests.patch (40.5 kB) - added by pgiraud on 11/27/07 08:54:55.
(complete) tests for Renderer, Elements, SVG, VML
renderers_tests.3.patch (57.9 kB) - added by pgiraud on 12/03/07 06:01:45.

Change History

11/08/07 00:04:15 changed by elemoine

Thanks for working on these tests pgiraud. This is great I think.

11/08/07 08:14:22 changed by fredj

Pierre, can you remove the numbers in test function names ?

see #952

11/08/07 09:56:39 changed by pgiraud

  • attachment renderers_tests.2.patch added.

tests for Renderer, Elements (almost complete), SVG

11/27/07 06:08:30 changed by fredj

  • keywords set to review.

Pierre,

Your patch looks good to me, thanks for your work !

11/27/07 07:37:50 changed by crschmidt

pierre: your VML tests aren't included in the patch?

11/27/07 08:54:55 changed by pgiraud

  • attachment renderers_tests.patch added.

(complete) tests for Renderer, Elements, SVG, VML

12/01/07 10:03:23 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • resolution set to fixed.

(In [5319]) Renderer tests, from pgiraud. (Thx!) (Closes #1128)

12/01/07 14:13:10 changed by elemoine

  • status changed from closed to reopened.
  • resolution deleted.

r5319 doesn't include tests for the concrete renderer classes (SVG et VML)!

12/01/07 14:16:11 changed by crschmidt

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [5320]) Fix a mistake in my commit of the tests: forgot to 'svn add' the directory I needed. Good catch, elemoine. (Closes #1128)

12/01/07 16:36:27 changed by pgiraud

  • status changed from closed to reopened.
  • resolution deleted.

I should have said that tests don't pass on IE (Renderer/test_Elements.html). I should work on that on monday.

12/01/07 16:38:04 changed by crschmidt

Well that sucks :)

I had run the tests in IE (brought my IE machine home this weekend just for that) and got no failures, but maybe I just failed to actually run them somehow.

Hooray for creating a mess! Sorry about that.

12/02/07 07:30:42 changed by elemoine

Also, Renderer/test_Elements.html fails, for various reasons.

I made a patch for that. See <http://trac.openlayers.org/ticket/1184>. Note that the last patch added (patch-1184-r5324-B0.diff) takes Andreas' changes for #1172 into account.

12/03/07 06:01:31 changed by pgiraud

The new patch renderers_tests.3.patch fixes several problems :

  • duplicate code is removed from test_SVG.js and test_VML.js,
  • semi-colons added,
  • eraseGeometry test is updated and now pass on IE.

This should close this ticket.

12/03/07 06:01:45 changed by pgiraud

  • attachment renderers_tests.3.patch added.

12/04/07 08:41:17 changed by elemoine

  • status changed from reopened to closed.
  • resolution set to fixed.

fixed in r5340