OpenLayers OpenLayers

Ticket #1129 (closed bug: fixed)

Opened 10 months ago

Last modified 6 months ago

popup text is not selectable

Reported by: tschaub Assigned to: euzuro
Priority: minor Milestone: 2.6 Release
Component: Map Version: 2.5
Keywords: Cc:
State: Complete

Description

Because of the -moz-user-select style declaration.

Modifying style.css to 

div.olMapViewport {
   /*-moz-user-select: none */
}

fixes this problem - but surely creates others if there was some reason for this.

It seems to me that 

.olPopupContent {
    -moz-user-select: normal;
}

Should override the previous declaration, but things are not this simple.

Attachments

popup_select.patch (0.6 kB) - added by crschmidt on 02/09/08 09:50:50.

Change History

11/07/07 12:56:01 changed by tschaub

And this was added here http://trac.openlayers.org/changeset/1695#file37

11/07/07 12:58:09 changed by tschaub

and I guess more significantly: http://trac.openlayers.org/attachment/ticket/272/selecttiles.patch

01/22/08 17:42:33 changed by crschmidt

  • state changed.
  • milestone changed from 2.6 Release to 2.7 Release.

Mass ticket move to 2.7 post dev meeting. If you are actively working on this task, please update this ticket with information and change the milestone to 2.6. At the time of the next IRC meeting (most likely 1-31-08), this will mean the ticket can *not* be brought back into 2.6 unless there is further feedback.

01/25/08 14:29:34 changed by euzuro

  • status changed from new to assigned.
  • component changed from Popup to Map.
  • milestone changed from 2.7 Release to 2.6 Release.

this is an important ticket and i'd like to see it handled in 2.6 if possible. seems like the best solution will probably something like adding that property to the individual layer divs, so as to protect the popups and also the controls. at some point, users might want to select-copy the names of the layers from the layerswitcher, for example.

02/09/08 09:50:50 changed by crschmidt

  • attachment popup_select.patch added.

02/09/08 09:52:17 changed by crschmidt

  • state set to Review.

There are additional problems for the LayerSwitcher and other controls: specifically, we catch the mousedown events in the layerswitcher, so they don't get through. However, that's a seperate issue: this patch makes it so that text in the default popup is selectable by adding a className to layers, and then setting the no-select property on that instead of on the map.

02/09/08 14:31:49 changed by tschaub

  • state changed from Review to Commit.

Very good sir. Please commit.

02/09/08 14:35:27 changed by crschmidt

  • status changed from assigned to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [6176]) Make popup text selectable in Firefox. (Closes #1129)