OpenLayers OpenLayers

Ticket #1147 (assigned feature)

Opened 8 months ago

Last modified 2 days ago

IE problem : to avoid teardown problems with IE, deactivate controls first

Reported by: cph Assigned to: euzuro (accepted)
Priority: major Milestone: 2.7 Release
Component: Map Version: 2.5
Keywords: Cc:
State:

Description

If the controls of a map are not deactivated before layers are destroyed, then IE will report JS problems as the controls (Point, Drag) will not have a layer to destroy.

Patch attached.

Attachments

map.patch (0.6 kB) - added by cph on 11/13/07 10:58:35.

Change History

11/13/07 10:58:35 changed by cph

  • attachment map.patch added.

11/14/07 14:36:42 changed by elemoine

Could you provide a patch with the appropriate path - do svn diff at OpenLayers root dir.

Also, for your patch to have better chance to make it into trunk, provide tests. See http://trac.openlayers.org/wiki/CreatingPatches.

You can mark the patch as review (Keywords) once it's ready for review.

07/04/08 02:17:18 changed by euzuro

  • owner set to euzuro.
  • status changed from new to assigned.
  • state changed.
  • milestone set to 2.7 Release.

to me, this doesn't seem like the right approach to fix this problem. I don't think a control should have to be deactivate()d in order to be destroy()ed without causing errors.

This either means that we need to add a call to this.deactivate() in the generic control class's destroy() or else change the logic in the individual controls so as to avoid this error.