OpenLayers OpenLayers

Ticket #1179 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

event pane layers with padding drag funny

Reported by: tschaub Assigned to: euzuro
Priority: critical Milestone: 2.7 Release
Component: Layer.EventPane Version: 2.5
Keywords: Cc:
State: Complete

Description

Attachments

killMarginPadding.patch (324 bytes) - added by euzuro on 07/28/08 17:02:05.
once we have schaub's classname patch in, we need to automatically assign the main map div a 'olMap' classname, and then this mod to the style.css will fix the stated problem.
killMarginPadding.2.patch (0.8 kB) - added by euzuro on 07/28/08 17:50:34.
ok. classname patch is in, so here is the big poobah.
noPaddingMargin.patch (1.6 kB) - added by crschmidt on 07/29/08 09:20:12.
same patch, with a test for olMap class

Change History

07/04/08 03:21:17 changed by euzuro

  • state changed.
  • milestone set to 2.7 Release.

this sounds like #1116 to me. can someone corroborate that?

my brain is saying "close all these tickets in favor of one big ticket that explains the 'dont use x,y,z styles on your map div or any parent divs thereof' issue... which hopefully can either be solved somehow or (more likely) we can at least print a clear notification somewhere in the code/documentation so people know about this"

07/28/08 12:30:58 changed by crschmidt

  • priority changed from minor to critical.

Turn off padding in CSS. Force it to 0px because we own it.

07/28/08 17:02:05 changed by euzuro

  • attachment killMarginPadding.patch added.

once we have schaub's classname patch in, we need to automatically assign the main map div a 'olMap' classname, and then this mod to the style.css will fix the stated problem.

07/28/08 17:02:17 changed by euzuro

  • state set to Needs More Work.

07/28/08 17:50:34 changed by euzuro

  • attachment killMarginPadding.2.patch added.

ok. classname patch is in, so here is the big poobah.

07/28/08 18:11:41 changed by euzuro

  • state changed from Needs More Work to Review.

all tests pass ff2, ie7* (despite your mockery).

please review

*excepting overviewmap which has speed issue

07/28/08 18:26:49 changed by euzuro

when this is approved and committed, I can go ahead and make patch for #1635

07/28/08 19:00:01 changed by euzuro

  • status changed from new to assigned.

07/29/08 09:20:12 changed by crschmidt

  • attachment noPaddingMargin.patch added.

same patch, with a test for olMap class

07/29/08 09:23:59 changed by crschmidt

  • state changed from Review to Commit.

Erik,

Checked it out, made sure that the Map div now gets an olMap class (test included in my most recent patch) and that the CSS rules are applied on examples/lite.html. Tested it by setting margin/padding of 1000px on the map element with no problems. 'hit it.'

07/29/08 10:52:48 changed by euzuro

  • status changed from assigned to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [7584]) patch to make sure main openlayers map div has neither padding nor margin. done via css thanks to tim's fabulous new class manip patch. r=cr5 (Closes #1179)

07/29/08 10:57:57 changed by euzuro

accidentally added a change to Events.js with r7584 -- reverted in r7585