OpenLayers OpenLayers

Ticket #1272 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

GPX Format class

Reported by: crschmidt Assigned to: crschmidt
Priority: critical Milestone: 2.7 Release
Component: Format Version: 2.5
Keywords: Cc:
State: Complete

Description

GPX Format class allows for parsing of GPX-formatted files into linear features.

Attachments

GPXformat.patch (7.5 kB) - added by edgemaster on 05/02/08 18:38:49.
GPX format based on crschmidt's original workings, tests included
t1272r7446.Format.GPX.patch (10.7 kB) - added by edgemaster on 06/28/08 04:22:01.
most recent version of the GPX format class

Change History

01/22/08 14:40:23 changed by crschmidt

  • milestone changed from 2.6 Release to 2.7 Release.

05/02/08 18:38:49 changed by edgemaster

  • attachment GPXformat.patch added.

GPX format based on crschmidt's original workings, tests included

05/02/08 18:40:20 changed by edgemaster

  • owner changed from crschmidt to edgemaster.
  • status changed from new to assigned.
  • state set to Review.

Can this be reviewed please?

Format class originally by crschmidt, modified by me, tests by me.

05/14/08 15:13:15 changed by jpulles

In GPX.js the following lines 

 50  for (var j = 0; j < segs.length; j++) {
 51    var track = this.extractSegment(segs[i], "trkpt");

should be changed because of the incorrect usage of i in segs[i]: 

 50  for (var j = 0; j < segs.length; j++) {
 51    var track = this.extractSegment(segs[j], "trkpt");

Regards, John.

05/15/08 07:00:49 changed by edgemaster

  • state changed from Review to Needs More Work.

Thanks for that, John, I'll fix up the patch and add 'attribute' extraction to the format also.

(follow-up: ↓ 6 ) 05/26/08 03:06:26 changed by jpulles

There is also an error when the features need to be reprojected. Waypoints are stored as points, not as features with a geometry property that has a transform function.

(in reply to: ↑ 5 ) 05/26/08 18:03:59 changed by edgemaster

Replying to jpulles:

There is also an error when the features need to be reprojected. Waypoints are stored as points, not as features with a geometry property that has a transform function.

This was fixed in r7058, the patch included with this ticket has never had this issue.

06/28/08 04:22:01 changed by edgemaster

  • attachment t1272r7446.Format.GPX.patch added.

most recent version of the GPX format class

06/28/08 04:25:15 changed by edgemaster

  • state changed from Needs More Work to Review.

Extraction of attributes is now supported, specific types of features can be selected for extraction also.

Bug noted by John is also fixed.

This patch has been sitting around for about a week, waiting to be added.

GPX test passes in ff2, untested in other browsers.

07/28/08 14:12:07 changed by euzuro

  • owner changed from edgemaster to crschmidt.
  • status changed from assigned to new.

07/28/08 14:16:03 changed by euzuro

  • priority changed from minor to critical.

07/29/08 16:03:18 changed by crschmidt

  • status changed from new to closed.
  • state changed from Review to Complete.
  • resolution set to fixed.

r7590