OpenLayers OpenLayers

Ticket #1325 (new feature)

Opened 5 months ago

Last modified 4 months ago

Tolerance and cancelling for the drag control

Reported by: sbenthall Assigned to: sbenthall
Priority: minor Milestone: 2.7 Release
Component: Control.DragFeature Version: 2.5
Keywords: Cc:
State: Review

Description

A useful feature for the DragFeature control would be a way to set a minimum amount of pixel-distance or time necessary for a drag to "count." We've gotten a lot of cases of accidentally drags, and this would provide a way for correcting for that.

Attachments

Panel.js.diff2 (0.7 kB) - added by sbenthall on 02/07/08 12:08:23.
redrawing patch for Panel.js
Panel.js.2.diff (0.7 kB) - added by sbenthall on 02/07/08 12:09:41.
redrawing patch for Panel.js
DragFeature.js.diff (5.6 kB) - added by sbenthall on 02/07/08 15:18:00.
patch to DragFeature.js

Change History

02/07/08 12:08:23 changed by sbenthall

  • attachment Panel.js.diff2 added.

redrawing patch for Panel.js

02/07/08 12:09:41 changed by sbenthall

  • attachment Panel.js.2.diff added.

redrawing patch for Panel.js

02/07/08 12:12:18 changed by sbenthall

I don't know what I've been doing with these patches. neither is relevant. Sorry

02/07/08 15:18:00 changed by sbenthall

  • attachment DragFeature.js.diff added.

patch to DragFeature.js

02/07/08 15:21:18 changed by sbenthall

  • state set to Review.
  • milestone set to 2.7 Release.

The patch to DragFeature.js is actually relevant to this ticket.

I think that as written, the patch may be dependent on the solution to #1326 (patch already provided) in line 303, but this could be easily changed if that ticket/patch is rejected. (If, on the other hand, that ticket and patch are accepted into trunk, then the code of this class could be tightened up in a couple other places by using that Feature.Vector.move() method)

04/04/08 11:31:58 changed by tcoulter

As far as I know, we don't use the code in the above patch above anymore, and we're not likely to support it in the future (we'd be happy to answer questions, however). If you don't find anything interesting in the patch above, feel free to ignore it.

04/04/08 11:32:53 changed by tcoulter

Addendum: I'm referring specifically the the DragFeature.js patch, and not the patches regarding Panel.js.