OpenLayers OpenLayers

Ticket #1332 (reopened task)

Opened 6 months ago

Last modified 6 months ago

Functionalize out cleanup behavior from Point handler cancel and finalize methods

Reported by: sbenthall Assigned to: sbenthall
Priority: minor Milestone: 2.7 Release
Component: Handler.Point Version: 2.5
Keywords: Cc:
State: Needs More Work

Description

There is some almost identical code in the Point handler's finalize() and cancel() methods. This should be functionalized out.

Attachments

Point.js.patch (1.2 kB) - added by sbenthall on 02/07/08 16:10:57.
Patch to Handler.Point

Change History

02/07/08 16:10:57 changed by sbenthall

  • attachment Point.js.patch added.

Patch to Handler.Point

02/07/08 16:11:11 changed by sbenthall

  • owner changed from tschaub to sbenthall.

02/08/08 19:49:38 changed by crschmidt

  • status changed from new to closed.
  • state changed from Review to Complete.
  • resolution set to fixed.

(In [6154]) Refactor Hanadler.Point cancel/finalize to just call a cleanup and pass a callback type, since otherwise they're the same thing. From sbenthall, r=me (Closes #1332)

02/08/08 23:24:37 changed by crschmidt

  • status changed from closed to reopened.
  • state changed from Complete to Needs More Work.
  • resolution deleted.
  • milestone changed from 2.6 Release to 2.7 Release.

This breaks drawing linear features: draw one, then mouse around the map, and you'll see that the events aren't properly completed. Marking for 2.7 unless someone cares about working on it before then.