OpenLayers OpenLayers

Ticket #1357 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

Z-indexing/Y-ordering Patch

Reported by: tcoulter Assigned to: euzuro
Priority: critical Milestone: 2.7 Release
Component: Layer.Vector Version: 2.5
Keywords: Cc:
State: Complete

Description

Attached is a patch for z-indexing/y-ordering for external graphics.

For an example of how to use z-indexing, see here:

Notice the "graphicZIndex" attribute attached to a feature's style. For this example, there's also a backgroundGraphicZIndex attribute; this is not included in this patch, and is instead an application specific variable.

To set a vector layer to use y-ordering in addition to z-indexing, pass the option {ordering: "y"} to the Vector layer. Example here:

Attachments

ordering.diff (16.3 kB) - added by tcoulter on 02/11/08 17:28:00.
ordering-updated.patch (16.7 kB) - added by tcoulter on 04/03/08 13:58:50.
Updated ordering patch that includes support for background graphics.
orderingforreview.patch (26.5 kB) - added by tcoulter on 07/28/08 18:38:39.
Ordering patch slated for review.
reviewwithexample.patch (34.9 kB) - added by tcoulter on 07/29/08 15:09:18.
Now with example! :)
ordering.patch (41.2 kB) - added by euzuro on 07/31/08 09:45:23.
some stylistic updates and testing updates... still not finished but getting there!
ordering.2.patch (32.2 kB) - added by tcoulter on 07/31/08 10:41:54.
Updated ordering patch with background graphic/shadow example.
ordering.3.patch (46.8 kB) - added by tcoulter on 07/31/08 10:43:51.
Oops. Forgot to add new files to svn.
marker_shadow.png (374 bytes) - added by tcoulter on 07/31/08 11:21:47.
The shadow image for marker shadown.
ordering.4.patch (47.8 kB) - added by tcoulter on 07/31/08 12:21:07.
Fixed erasing of background nodes.

Change History

02/11/08 17:28:00 changed by tcoulter

  • attachment ordering.diff added.

02/11/08 17:45:58 changed by crschmidt

  • milestone changed from 2.6 Release to 2.7 Release.

04/03/08 13:58:50 changed by tcoulter

  • attachment ordering-updated.patch added.

Updated ordering patch that includes support for background graphics.

04/03/08 14:00:05 changed by tcoulter

Just added an updated patch for the ordering stuff that includes support for background graphics. Originally, background graphics -- such as shadows -- were the motivation for writing the ordering code. The two are very coupled, so I've lumped them into one patch.

07/28/08 14:16:09 changed by euzuro

  • priority changed from minor to critical.

07/28/08 14:27:44 changed by euzuro

  • owner changed from euzuro to tcoulter.

07/28/08 18:38:11 changed by tcoulter

Attaching a new patch which I'll be slating for review. This patch includes everything in the ordering-updated.patch as well as fixes for tests that ordering-updated.patch broke. The tests were slightly rewritten to reduce complexity and code duplication.

07/28/08 18:38:39 changed by tcoulter

  • attachment orderingforreview.patch added.

Ordering patch slated for review.

07/28/08 18:43:51 changed by tcoulter

  • owner changed from tcoulter to euzero.

07/29/08 08:56:13 changed by tcoulter

  • owner changed from euzero to euzuro.

07/29/08 15:08:37 changed by tcoulter

Alright, new patch. This time, there's an example (examples/ordering.html), as well as changed the way y-ordering is specified on the layer (you don't use "z", and "y" anymore; you just say yOrdering: true).

07/29/08 15:09:18 changed by tcoulter

  • attachment reviewwithexample.patch added.

Now with example! :)

07/31/08 09:45:23 changed by euzuro

  • attachment ordering.patch added.

some stylistic updates and testing updates... still not finished but getting there!

07/31/08 10:41:54 changed by tcoulter

  • attachment ordering.2.patch added.

Updated ordering patch with background graphic/shadow example.

07/31/08 10:43:51 changed by tcoulter

  • attachment ordering.3.patch added.

Oops. Forgot to add new files to svn.

07/31/08 11:21:47 changed by tcoulter

  • attachment marker_shadow.png added.

The shadow image for marker shadown.

07/31/08 12:21:07 changed by tcoulter

  • attachment ordering.4.patch added.

Fixed erasing of background nodes.

07/31/08 19:17:59 changed by euzuro

  • keywords deleted.
  • status changed from new to closed.
  • state changed from Review to Complete.
  • resolution set to fixed.

(In [7652]) ordering <exclamation point/>. you can now gracefully z-order your vectors... and you can even 'yOrder' them and add background images, making for a nice 3dish look. be sure to check out the two new example html's: marker-shadow.html and ordering.html. Big thanks to tcoulter (funkyc) for a prolonged effort with this patch. It has come a long way and now what a beautiful finish. (Closes #1357)

09/05/08 01:08:42 changed by euzuro

  • component changed from general to Layer.Vector.