HOWTO: Enable zoom out with right-dblclick

interesting. did not know about this, but seems like a good idea

Right mouse events patch added. I am not familiar yet with the test suite so there are currently no tests installed with the patch. There is also currently no option to turn on/off the support from the OpenLayers.Map hence this patch overrides the oncontextmenu (default right click) event. Browser events added in OpenLayers.Events are rightclick and dblrightclick. Currently implemented in Controls.Navigation is a new method called defaultRightDblClick which support the zoom out functionality. David Martin

Shouldn't you do something like that instead?

    mouseup:  function (evt) { 
      var propagate = true; 
      // Collect right mouse clicks from the mouseup 
      // IE - ignores the second right click in mousedown so using mouseup instead 
      if (this.checkModifiers(evt) && OpenLayers.Event.isRightClick(evt)) { 
         return this.rightclick(evt);             
      } 
      return propagate; 
    },

in order to propagate the "propagate" of the rightclick method...

Yes correct I will modify the patch and upload a new version. Thanks for pointing this out.

This version corrects the return missing for the event generated in the Click.js

Since not all browsers support capturing the right-click event, or perhaps don't recognize the oncontextmenu event, might it be appropriate to allow the ctrl/meta keys to act as surrogates for the right click?

isRightClick: function(event) {
        return (((event.which) && (event.which == 3)) ||
                ((event.button) && (event.button == 2)) || 
                (event.metaKey || event.ctrlKey));
    },

adding APIProperty 'handleRightClicks' to allow for the turning on/off of this feature. default is off.

tests pass in ff2 and ie7. this is a fun patch. please review.

This looks good and does not negatively affect existing functionality. Please commit.

Replying to openlayers:

Since not all browsers support capturing the right-click event, or perhaps don't recognize the oncontextmenu event, might it be appropriate to allow the ctrl/meta keys to act as surrogates for the right click? {{{ isRightClick: function(event) { return (((event.which) && (event.which == 3)) ((event.button) && (event.button == 2))

(event.metaKey event.ctrlKey)); }, }}}

I think this is a good idea, but let's address it separately. See #1703

(In [7872]) Add support in OL for right-click capturing, including dbl-right-clicks (for zooming out in navigation control). Thanks to David Martin for this nice patch and the great 8 foot austrian for his review (Closes #1359)

as noted by chris r. on the mailing list:

I have noticed the following oddity in a patch attached to ticket #1359, at line 152:

http://trac.openlayers.org/attachment/ticket/1359/rightClicks.patch

       144             var propagate = true;
       145
       146             // Collect right mouse clicks from the mouseup
       147             //  IE - ignores the second right click in mousedown so using
       148             //  mouseup instead
       149             if (this.checkModifiers(evt) &&
       150                 this.control.handleRightClicks &&
       151                 OpenLayers.Event.isRightClick(evt)) {
       152               propogate = this.rightclick(evt);
       153             }
       154
       155             return propagate;

Surely that should be "propagate" rather than "propogate"?

fix for typo includes regression tests.

i can't run the unit tests now, if they pass please commit. Thanks for the patch Erik.

all tests pass ff2, ie7. committing....

(In [8207]) fix propogate/propagate typo in click handler. thanks to chris r. for finding this, elemoine for the review. (Closes #1359)