OpenLayers OpenLayers

Ticket #1362 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

looking for properties in rules symbolizer may fails

Reported by: pgiraud Assigned to:
Priority: critical Milestone: 2.6 Release
Component: Style Version: 2.5
Keywords: Cc:
State: Complete

Description

For some reason, some framework overwrite javascript native objects. It's the case for arrays in ExtJs for example, which adds a new remove method. The findPropertyStyles method fails because this remove property doesn't have a symbolizer property.

The following patch first checks if a symbolizer property exists. If not, then don't do anything but don't crash, please !

Attachments

1362-r6245-A0.diff (1.1 kB) - added by pgiraud on 02/13/08 09:05:22.
1362-r6245-B0.diff (0.7 kB) - added by ahocevar on 02/13/08 10:20:27.

Change History

02/13/08 09:05:22 changed by pgiraud

  • attachment 1362-r6245-A0.diff added.

02/13/08 09:32:03 changed by pgiraud

  • state set to Review.

Test are OK under FF2 and IE6.

02/13/08 10:20:27 changed by ahocevar

  • attachment 1362-r6245-B0.diff added.

02/13/08 10:21:54 changed by ahocevar

Pierre: my bad, used the hash flavour of the for-loop instead of the array flavour. Your patch works, but does not solve the original flaw. Can you please confirm if 1362-r6245-B0.diff works for you?

02/13/08 10:38:34 changed by ahocevar

  • type changed from feature to bug.

02/13/08 10:57:13 changed by elemoine

  • state changed from Review to Commit.

Andreas, your patch fixes the problem. Please commit if tests pass.

02/13/08 12:21:47 changed by ahocevar

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [6246]) looking for properties in rules symbolizer may fail. r=elemoine (closes #1362)