OpenLayers OpenLayers

Ticket #1389 (new bug)

Opened 4 months ago

Last modified 4 months ago

ctrl + clik doesn't work as expected for SelectFeature control

Reported by: pgiraud Assigned to: tschaub
Priority: major Milestone:
Component: Control.SelectFeature Version: 2.5
Keywords: Cc:
State: Needs More Work

Description

Expected behavior :

  • click on a selected feature unselect it,
  • click on a unselected feature select it by adding it to the current selected features list.

Current behavior :

  • click on a selected feature unselect it (correct),
  • click on a unselected feature select it but also unselects all other selected features (wrong)

Attachments

1389_r6365_A.diff (0.6 kB) - added by pgiraud on 02/25/08 11:56:33.

Change History

02/25/08 11:56:33 changed by pgiraud

  • attachment 1389_r6365_A.diff added.

02/25/08 11:57:41 changed by pgiraud

  • state set to Review.

This patch seems to fix the problem. It probably needs more work though.

03/04/08 11:24:09 changed by pgiraud

Eric and I just had a quick discussion on that before he left. In my opinion, we don't need to deal with two different keys (shift and ctrl). Only one would be enough for the expected behavior. In fact, I'm a bit confused with the ctrl key allowing user to toggle a feature selection. I think that the 'multiple' key can also allow un-selection. In this case, crtl key listener is not required anymore. Inkscape is probably a good application example to look at.

03/04/08 11:24:14 changed by pgiraud

  • state changed from Review to Needs More Work.