OpenLayers OpenLayers

Ticket #1452 (closed feature: fixed)

Opened 6 months ago

Last modified 1 month ago

WMC does not read/write metadataURLs

Reported by: bartvde Assigned to: tschaub
Priority: major Milestone: 2.7 Release
Component: Format.WMC Version: 2.5
Keywords: Cc:
State: Complete

Description

I'll attach a patch to implement this.

Attachments

ticket1452.patch (2.0 kB) - added by bartvde on 03/19/08 10:41:18.
ticket1452.2.patch (1.7 kB) - added by bartvde on 03/19/08 10:41:51.

Change History

03/19/08 10:41:18 changed by bartvde

  • attachment ticket1452.patch added.

03/19/08 10:41:51 changed by bartvde

  • attachment ticket1452.2.patch added.

03/31/08 02:32:45 changed by crschmidt

I don't generally have a problem with the purpose or tactics of this patch, but I am somewhat concerned about the fact that we're using one global namespace (the object) for options that OpenLayers cares about and options that OpenLayers doesn't care about: do we want something like a 'metadata' property of the layer for storing stuff like this?

03/31/08 02:32:56 changed by crschmidt

  • state set to Needs Discussion.

03/31/08 02:56:30 changed by bartvde

Hi Chris, I would be okay with a metadata hash (I guess you got the name from Mapserver's METADATA?).

03/31/08 02:58:05 changed by crschmidt

No, it just seems to me that there is data about the layer like where it came from, etc. that isn't really an 'option' in the way we usually look at them.

I'm not yet to a point where I want to say "Go out and do this", so don't write a new patch yet :) I'm just pondering at the moment.

07/28/08 14:56:12 changed by euzuro

  • priority changed from minor to critical.

07/30/08 10:55:16 changed by euzuro

  • priority changed from critical to major.

07/30/08 17:00:28 changed by crschmidt

  • state changed from Needs Discussion to Review.

I withdraw my comment on this. I don't really care either way :)

07/30/08 20:00:28 changed by crschmidt

  • status changed from new to closed.
  • state changed from Review to Complete.
  • resolution set to fixed.

(In [7626]) Fix for WMC does not read/write metadataURLs. This matches the style of other similar properties in the code, and has a negligable (<5%) impact on parsing speed in Firefox/Safari. patch from bartvde, (Closes #1452)