OpenLayers OpenLayers

Ticket #1458 (closed feature: fixed)

Opened 5 months ago

Last modified 5 months ago

Support for writing SLD

Reported by: tschaub Assigned to: tschaub
Priority: minor Milestone: 2.6 Release
Component: Format.SLD Version: 2.5
Keywords: Cc:
State: Complete

Description

To compliment the read support for SLD, having write would be nice. This requires some changes to the structure of the output from read (so round-tripping SLD is possible) and requires some changes to Style and Rule(s).

Attachments

sld.patch (91.2 kB) - added by tschaub on 03/21/08 18:21:46.
rewrite
1458-r6638-A0.patch (84.6 kB) - added by ahocevar on 03/27/08 09:35:51.
Same as Tim's patch, but with additional visual tests in the sld example and a correct (inclusive) PropertyIsBetween filter with modified tests.
1458.patch (84.5 kB) - added by crschmidt on 03/27/08 09:44:44.
same as above, with html preview available, hopefully
1458-r6638-A1.patch (98.9 kB) - added by ahocevar on 03/27/08 12:45:04.
same as above (hopefully again with html preview), but with the Format/SLD subfolder that was missing in the previous two patches.

Change History

03/21/08 18:21:46 changed by tschaub

  • attachment sld.patch added.

rewrite

03/24/08 03:49:49 changed by ahocevar

  • state set to Needs Discussion.
  • milestone set to 2.6 Release.

Setting milestone to 2.6. At least the changes to Format.SLD.read should go into 2.6, so we do not have to change the API later. Depending on how much time is left until 2.6, we would either have to

  • review and test this patch quickly to get everything into 2.6, or
  • split the patch into two pieces: one for the changes required for the new read return, and one for the other changes (write support)

03/26/08 16:28:12 changed by crschmidt

  • state changed from Needs Discussion to Needs More Work.

03/27/08 03:48:35 changed by ahocevar

I am working on additional tests, will upload a new patch in a few hours.

03/27/08 09:35:51 changed by ahocevar

  • attachment 1458-r6638-A0.patch added.

Same as Tim's patch, but with additional visual tests in the sld example and a correct (inclusive) PropertyIsBetween filter with modified tests.

03/27/08 09:44:44 changed by crschmidt

  • attachment 1458.patch added.

same as above, with html preview available, hopefully

03/27/08 12:45:04 changed by ahocevar

  • attachment 1458-r6638-A1.patch added.

same as above (hopefully again with html preview), but with the Format/SLD subfolder that was missing in the previous two patches.

03/27/08 12:48:26 changed by ahocevar

  • state changed from Needs More Work to Review.

Finally, 1458-r6638-A1.patch contains all required files, has a HTML preview, a correct PropertyIsBetween rule and more visual tests in exmaples/sld.html.

Tests pass in FF2 and IE6. MapBuilder examples work fine with this version, also all my applications that use SLD.

Marking as Review (because it was "Needs More Work" before), but IMO this is good to commit.

03/27/08 13:14:38 changed by tschaub

Thanks for the review ahocevar. My read of this is that the only change between your patch and mine is the addition of two options in the example and a correction to the existing test_Comparison.html (which is unrelated to the new SLD read/write code). Let me know if that is wrong. Assuming it is right, I'll take your review as a commit.

03/27/08 13:18:05 changed by tschaub

  • status changed from new to closed.
  • state changed from Review to Complete.
  • resolution set to fixed.

(In [6645]) SLD format rewrite. Adds a versioned parser with read and write support. This does not come with full support for ogc:expression parsing, but makes for easy future enhancements. r=ahocevar (closes #1458)