OpenLayers OpenLayers

Ticket #1463 (closed bug: fixed)

Opened 8 months ago

Last modified 8 months ago

SVG support for Safari 3.1

Reported by: openlayers Assigned to:
Priority: blocker Milestone: 2.6 Release
Component: Renderer Version: SVN
Keywords: Cc: sypasche
State: Complete

Description

OpenLayers returns the error "Your browser does not support vector rendering" if rendering vector graphics with Safari 3.1. Safari 3.0 works. Verified with Mac OS 10.4 and Windows XP. Verified also with OpenLayers 2.5.

Attachments

svg.supported.patch (0.9 kB) - added by crschmidt on 03/25/08 13:10:49.
add BasicStructure test, confirmed to pass in Safari nightly, suggested by #17400

Change History

03/25/08 11:00:24 changed by crschmidt

Ugh, I was really hoping they wouldn't ship with this behavior. What a pain.

We need ot change our supported() call to do something different for Safari.

03/25/08 12:47:51 changed by sypasche

That should be fixed in WebKit now: http://bugs.webkit.org/show_bug.cgi?id=10297

This page might be useful for selecting the feature to check: http://www.din.or.jp/~hagi3/JavaScript/JSTips/Mozilla/Samples/hasFeature.htm (I don't have a Safari 3.1 handy to check).

03/25/08 12:48:07 changed by sypasche

  • cc set to sypasche.

(follow-up: ↓ 9 ) 03/25/08 13:10:13 changed by crschmidt

sypasche: You'll need to add a full email address to get CCs. Sorry.

Can you define "fixed"? Webkit is now *accurate*: it still returns false for our current test.

03/25/08 13:10:49 changed by crschmidt

  • attachment svg.supported.patch added.

add BasicStructure test, confirmed to pass in Safari nightly, suggested by #17400

03/25/08 13:11:34 changed by crschmidt

  • state set to Review.

http://bugs.webkit.org/show_bug.cgi?id=17400 suggests the use of BasicStructure instead: use that in addition to our current checks. Confirmed in Safari 3.1 on Windows, and Safari nightly on Mac.

03/25/08 13:13:29 changed by crschmidt

Tests continue to pass in FF, and shouldn't affect IE at all (since document.implementation check will return false and bail out of the test early), and work in Safari 3.0 as well.

03/25/08 13:21:53 changed by pspencer

  • state changed from Review to Commit.

I applied the patch and tried out some of the vector examples manually with Safari 3.1 and things are working. Without the patch, I get the error message. I also tried it in ff2 on "os x" and the examples work. I didn't run the tests, but I am happy with this change and I think you should go ahead and commit.

03/25/08 13:29:11 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [6581]) Add support for Safari 3.1 SVG version strings: Safari got more 'honest' about what it supports, at the cost of breaking OpenLayers Vector layers. This looks for a more 'basic' SVG featureset, as recommended by a Webkit developer. r=pagameba (Closes #1463)

(in reply to: ↑ 4 ) 03/25/08 13:31:09 changed by sypasche

Replying to crschmidt:

sypasche: You'll need to add a full email address to get CCs. Sorry.

Hmm, I still received the replies in this ticket, so maybe username also work?

Can you define "fixed"? Webkit is now *accurate*: it still returns false for our current test.

I thought they reverted their change to the previous behavior on their trunk. But I'm apparently wrong, sorry for the confusion.

03/25/08 13:32:51 changed by crschmidt

Perhaps you're on the OpenLayers-trac mailing list? We don't have any way to know your username, so I'm pretty sure you didn't get email as a result of being on the CC :)

And yeah, they're still working on getting Filter support done: until then, Feature#SVG will return false, as I understand it.