OpenLayers OpenLayers

Ticket #1472 (closed bug: fixed)

Opened 4 months ago

Last modified 4 months ago

Popup close image has to be in the skin's img folder

Reported by: ahocevar Assigned to: euzuro
Priority: blocker Milestone: 2.6 Release
Component: Popup Version: 2.5
Keywords: Cc:
State: Complete

Description

Now that the close image for popups is defined in css, it's location has to be changed to be in the skin's img folder. Otherwise, applications that set OpenLayers.ImgPath will not be able to display the close image any more.

The provided patch fixes that. In addition, close.gif has to be moved from img to theme/default/img.

Attachments

closeimg.patch (424 bytes) - added by ahocevar on 03/31/08 03:51:52.

Change History

03/31/08 03:51:52 changed by ahocevar

  • attachment closeimg.patch added.

03/31/08 03:52:26 changed by ahocevar

  • owner set to euzuro.
  • priority changed from minor to blocker.
  • state set to Review.
  • component changed from general to Popup.
  • milestone set to 2.6 Release.

03/31/08 07:16:07 changed by crschmidt

  • state changed from Review to Commit.

So, this breaks existing applications that have changed the image inside their img/ dir. I can't decide which one I care more about: people who use ImgPath, or people who have changed their close graphic.

Having wandered around for five minutes and thought about it, I think the answer is I care more about the former, so you've made the right call here.

Can you please add a note on this to http://trac.openlayers.org/wiki/Release/2.6/Notes ?

"""

If you have changed the graphic in the img/close.gif location, you will need to include a custom style in your webpage pointing to that file: see examples/custom-style.html for more information. An example CSS rule is: 

.olPopupCloseBox { 
  background-image: url("/my/openlayers/img/close.png");
}

"""

Once you've done that, please commit, and copy the close.gif into the theme dir with your commit.

03/31/08 07:23:15 changed by ahocevar

(In [6732]) move close button image for popups into the theme (references #1472)

03/31/08 07:24:29 changed by ahocevar

  • status changed from new to closed.
  • state changed from Commit to Complete.
  • resolution set to fixed.

(In [6733]) Popup close image is now in the theme's img folder (closes #1472)