VML renderer draws features in the upperleft corner of the map pane

More information, like an example of how to reproduce, is neccesary to take any action on this...

Shows how I can prevent the bug

I added a patch to show how I can prevent the bug to happen. It's not really a fix because I don't know the VML implementation. I hope this helps figuring the bug out. I tried to create example file of how to produce this bug, but I failed. If I figure it out later I'll post it here. I'm using IE 7.05730.11.

I'm not convinced by this patch since it reverses a previous change. See http://trac.openlayers.org/ticket/965

We won't be able to decide if this ticket is valid if you don't provide an example to reproduce.

Updated version of the way to prevent bug

I added a new patch, the first one had too much changes. "if (!document.namespaces.v)" fails in my code for some reason. The document.namespaces.v object already exists when this is first time called.

Maybe some other library that I'm using is already adding that same namespace. Then the style("position: relative; display: inline-block;") is never added and that's why the features are on the upperleft corner of the map. Is this something OpenLayers should handle or what should be done to fix this? For example Dojo seems to add the same namespace. From Dojo code: document.namespaces.add("v","urn:schemas-microsoft-com:vml"); document.createStyleSheet().addRule("v\\:*", "behavior:url(#default#VML)");

Ah, now *that* is a decent bug report. (Though of course, an example still would have been better, since I still can't tell when I fix it.)

So, The problem is that we use "Does the VML namespace exist?" as our test case for "Should we do some funky stuff relating to setting up OpenLayers + VML?"

However, other things can set the VML namespace -- dojo, as was pointed out,but you can even set it manually on the page (look at just about any Google Maps example). With that in mind, the thing to do here is probably to:

• Reproduce it
• Pull the "set position:relative" block out of that if

However, there is a problem here: It seems to me that we are breaking other existing VML, no? If someone else has VML rendered on their page, we're going to be applying rules to it?

So I think that means that we want to add this stylesheet rule *only* to the stuff we care about -- setting the rule on '.olMapViewport v:*' instead? perhaps we shouldn't even go that far, and just create a new rule for each VML renderer root -- otherwise, maps with multiple layers end up with duplicate stylesheet rules (Though I don't really see how that harms us, to be honest).

Because this is a regression (#1141), we're going to need a new RC. (Which means we need to go fix the popup issue too. Sigh.)

Pierre, for the record, you addressed this in your initial ticket as a question: "Though, I don't really know what happens if user already set a vml namespace in the HTML document but with no proper or wrong style sheet rules."

Now we know :)

Essentially, the patch here reverts the change in #1141. Since that code was *working*, it might be worth it to just go back to it, and re-address #1141 *not* during an RC cycle. I'm somewhat fearful of making a significant change to VML during an RC, simply because we know that IE is more poorly tested in general, and I don't want to miss something important at this point.

But I'll leave that call up tosomeone else.

May I propose that we just use a more unique namespace prefix for our vml? "olv:" instead of just "v:" should do. 1477-r6762-A0.patch works and passes tests in IE6.

I'm totally in favour of Adreas' proposal, and I can confirm that it still works for current examples. We are still awaiting for feedbacks from this ticket's reporter.

Nice. Namespacing for the win!

Pierre: I think we can commit this without further feedback from the user, since it is clear that this is the issue. If it doesn't solve the problem, I'm sure the user will come back to let us know :)

Andreas: Please commit, and include "(Pullup #1477)" in your commit message.

Thanks!

(In [6764]) changed vml namespace prefix from "v" to "olv" to avoid conflicts with other libraries that use vml. r=pgiraud,crschmidt. (Pullup #1477)

That solves the problem. Features works fine now. As far as I can see this issue is now fixed. Thank you.

(In [6819]) Pullup commits from trunk to 2.6 branch:

• virtualStyle typo (Closes #1495)
• JSON fix for Safari 3.1 (Closes #1493)
• panzoombar off-by-one (Closes #1486)
• Handler Hover exception (Closes #1480)
• Popup.framedcloud exception (Closes #1479)
• VML Renderer when including namespace in page (Closes #1477)
• SLD/Rule/Filter changes -- most of this commit (Closes #1492)