OpenLayers OpenLayers

Ticket #1486 (closed bug: fixed)

Opened 8 months ago

Last modified 8 months ago

clicking in panzoombar -> off by one

Reported by: crschmidt Assigned to: crschmidt
Priority: minor Milestone: 2.6 Release
Component: Control.PanZoomBar Version: 2.6 RC1
Keywords: Cc:
State: Complete

Description

Clicking in the panzoombar in 2.6 is always off-by-one.

http://crschmidt.net/mapping/2zooms.html http://crschmidt.net/mapping/2zooms-2.6.html

This is a regression that should be fixed before we ship 2.6.

Attachments

panzoombarfix.patch (2.1 kB) - added by crschmidt on 04/03/08 13:24:00.
panzoombar.patch (2.1 kB) - added by crschmidt on 04/06/08 23:57:05.

Change History

04/03/08 13:24:00 changed by crschmidt

  • attachment panzoombarfix.patch added.

04/03/08 13:26:19 changed by crschmidt

  • state set to Review.

Ran tests in FF + IE.

Test state:

  • 2.5 -- first test passes, fractionalzoom test fails
  • 2.6-rc1 -- first test fails, fractionalzoom test passes
  • trunk + patch -- both tests pass

This ensures that we're not regressing in the future; we're restoring the behavior that we had in 2.5.

04/06/08 23:57:05 changed by crschmidt

  • attachment panzoombar.patch added.

04/06/08 23:58:02 changed by crschmidt

Later patch moves duplicate code out: Now we just floor() if map.fractionalZoom is not true.

04/07/08 00:05:18 changed by euzuro

  • state changed from Review to Commit.

all tests pass in ie7.

go for it.

04/07/08 00:08:33 changed by crschmidt

  • keywords set to pullup.
  • state changed from Commit to Pullup.

(In [6799]) 2.6 accidentally broke behavior when clicking on the panzoombar. Thanks to Linda Rawson's report of this issue, this is now fixed, by moving the Math.floor call to a different part of the code. r=euzuro (Pullup #1486)

04/07/08 21:51:04 changed by crschmidt

  • keywords deleted.
  • status changed from new to closed.
  • state changed from Pullup to Complete.
  • resolution set to fixed.

(In [6819]) Pullup commits from trunk to 2.6 branch:

  • virtualStyle typo (Closes #1495)
  • JSON fix for Safari 3.1 (Closes #1493)
  • panzoombar off-by-one (Closes #1486)
  • Handler Hover exception (Closes #1480)
  • Popup.framedcloud exception (Closes #1479)
  • VML Renderer when including namespace in page (Closes #1477)
  • SLD/Rule/Filter changes -- most of this commit (Closes #1492)